Closed echoix closed 3 years ago
@echoix,
Could you please explain the following fix a bit in more detail?
fix the escaping of the \n to display \n in the UI
Because at first sight it seems to me that everything is already correctly displayed:
Or not?
English Original English: Fixed English:
French Original French: (not translated, stays in English) Fixed French:
Japanese Original Japanese: Fixed Japanese:
Dutch Original Dutch: Fixed Dutch:
Russian Original Russian: Fixed Russian:
And maybe one last thing that I wasn't able to verify. I couldn't find in the UI where the strings TIMER_CONDITIONAL, TIMER_COUNTING and their tooltips were used. It seems that they are used in lib/extra/extraBlocksDefs.js
, but the comments on these two files might seem to indicate that they are hidden for 3 years.
https://github.com/bartbutenaers/node-red-contrib-blockly/blob/5c9aef425c25718afc1632b893dd1f980c096703/lib/extra/extraBlocksCodeGen.js#L1-L27
https://github.com/bartbutenaers/node-red-contrib-blockly/blob/5c9aef425c25718afc1632b893dd1f980c096703/lib/extra/toolbox.xml#L2-L7
Seems that are two blocks to create an interval timer.
I might imagine that it would be nice to add both blocks in the future to the "Timers" category, as an extra alternative to the setInterval block (because they will result in less blocks for those specific use cases). After I have redesigned both blocks to work together with the clearInterval block.
So I would keep the texts. Any thoughts @cymplecy ?
No thoughts - brain is hurting too much :)
I think we'll let the strings there for sure, since the blocks that use them are still there and implemented. It was only a matter of knowing why they weren't available to use.
@echoix , Thanks a lot for this full review of all our translations!!!!! Bart
I suggest here another set of changes for the messages/*.js files. Mainly, uniformize the use of the official "Node-RED" spelling vs Node-Red, JavaScript instead of Javascript, formatting the files to remove blank spaces at the end of lines, fix the escaping of the
\\n
to display\n
in the UI.I will also add some comments of things I find weird within this PR.