Open Just-another-pleb opened 4 years ago
Hi, Makes sense about the 'calc' palette label. Will change it.
On your example page, the node's icon isn't show - just a blank function node. The actual node has a calculator icon.
That is not clear to me. On Github, npm and the Node-RED library I see the calculator icon in the example:
I think we are talking of different things.
1 - on the web page when searching for the node:
Confusing which is yours.
Going on the name:
Not quite.
So then I see:
Note the icon......
And the name has gone from calc
to calculator
But this is called calc
.
Then when I am editing it:
Not really helpful.
I'm only saying.
If that double posted, sorry.
I came back to check and I often find (or it seems) my post hadn't been posted.
It is still here/there in the edit window.
So I posted it again. Than I was told there is a similar comment.
Ooops.
Yes, it was double posted. I deleted the extra one.
No problem! 1) Cannot do much about the (similar) name. Before I publish my nodes on NPM, I always discuss the beta's on the Node-RED forum. As you can see here we have discussed the name of the node also, and at the end it became node-red-contrib-calc. Cannot change it anymore now, to avoid breaking existing flows. 2) I agree that I should show 'calc' instead of 'calculate' all over the place, to make it less confusing. Will change that tonight. 3) The reason of the missing icon is not clear to me at the moment. Perhaps because I use a FontAwesome icon in this node. Not sure. Will need to have a look tonight.
Of course I agree you can't do much about the other similar name.
It just threw me when your node goes by two names. No big. But thanks. It is handy and my recent use/need for it has been handy.
Keep up the good work.
Hi, bit later as expected ...
I have done some changes, in the local calc node on my pc:
You see now this in the palette:
And also in the flow (as long as you have no "Name" entered in the node's config screen):
And on top of the node's config screen:
So until here I must admit that it indeed looks less confusing.
However the underlying type in this repository is also calculator
:
And unfortunately that type is showed by Node-RED in the left sidebar in a couple of places:
All nodes have - until now - been saved by Node-RED with that calculator
type (in the flows.json file). So when I change that type to calc
, all existing flows will be broken:
You will understand that this is not possible anymore...
So question is now how to continue with this? I'm afraid that it will become even more confusing when we change it, because then we get a mix of "calc" and "calculator" for a single node ...
Any thoughts?
P.S. For the missing icon, I have logged an issue on the Node-RED forum.
I don't mind if you called them all calculator. That isn't a problem.
The problem is/was that in one part of Node-Red it is called one name and in another part it is called another name.
Can't you just make them all calculator
then?
You call this node
calc
, yet in the palette it is calledcalculator
. There is another node with a very similar name and it makes it annoying not having the node name match the name in the palette.https://flows.nodered.org/node/node-red-contrib-calculate
On your example page, the node's icon isn't show - just a blank function node.
The actual node has a calculator icon.
That too throws a spanner in the works when trying to find it.