bartbutenaers / node-red-contrib-calc

A Node-Red node to perform basic mathematical operations
Apache License 2.0
5 stars 1 forks source link

Suggestion. #7

Open Just-another-pleb opened 4 years ago

Just-another-pleb commented 4 years ago

You call this node calc, yet in the palette it is called calculator. There is another node with a very similar name and it makes it annoying not having the node name match the name in the palette. https://flows.nodered.org/node/node-red-contrib-calculate

On your example page, the node's icon isn't show - just a blank function node.

The actual node has a calculator icon.

That too throws a spanner in the works when trying to find it.

bartbutenaers commented 4 years ago

Hi, Makes sense about the 'calc' palette label. Will change it.

On your example page, the node's icon isn't show - just a blank function node. The actual node has a calculator icon.

That is not clear to me. On Github, npm and the Node-RED library I see the calculator icon in the example:

image

Just-another-pleb commented 4 years ago

I think we are talking of different things.

1 - on the web page when searching for the node:

Screenshot from 2020-09-08 22-09-44

Confusing which is yours.

Going on the name:

Screenshot from 2020-09-08 22-09-55

Not quite.

So then I see:

Screenshot from 2020-09-08 22-09-26

Note the icon...... And the name has gone from calc to calculator

But this is called calc.

Then when I am editing it:

Screenshot from 2020-09-08 22-12-17

Not really helpful.

I'm only saying.

Just-another-pleb commented 4 years ago

If that double posted, sorry.

I came back to check and I often find (or it seems) my post hadn't been posted.

It is still here/there in the edit window.

So I posted it again. Than I was told there is a similar comment.

Ooops.

Yes, it was double posted. I deleted the extra one.

bartbutenaers commented 4 years ago

No problem! 1) Cannot do much about the (similar) name. Before I publish my nodes on NPM, I always discuss the beta's on the Node-RED forum. As you can see here we have discussed the name of the node also, and at the end it became node-red-contrib-calc. Cannot change it anymore now, to avoid breaking existing flows. 2) I agree that I should show 'calc' instead of 'calculate' all over the place, to make it less confusing. Will change that tonight. 3) The reason of the missing icon is not clear to me at the moment. Perhaps because I use a FontAwesome icon in this node. Not sure. Will need to have a look tonight.

Just-another-pleb commented 4 years ago

Of course I agree you can't do much about the other similar name.

It just threw me when your node goes by two names. No big. But thanks. It is handy and my recent use/need for it has been handy.

Keep up the good work.

bartbutenaers commented 4 years ago

Hi, bit later as expected ...

I have done some changes, in the local calc node on my pc:

So until here I must admit that it indeed looks less confusing.

However the underlying type in this repository is also calculator:

So question is now how to continue with this? I'm afraid that it will become even more confusing when we change it, because then we get a mix of "calc" and "calculator" for a single node ...

Any thoughts?

P.S. For the missing icon, I have logged an issue on the Node-RED forum.

Just-another-pleb commented 4 years ago

I don't mind if you called them all calculator. That isn't a problem.

The problem is/was that in one part of Node-Red it is called one name and in another part it is called another name.

Can't you just make them all calculator then?