status light stay red even if connected

bartbutenaers / node-red-contrib-onvif-nodes

Node Red nodes for communicating with OnVif compliant IP devices

Apache License 2.0

67 stars 25 forks source link

status light stay red even if connected #12

Closed SuperNinja73 closed 4 years ago

SuperNinja73 commented 4 years ago

it remains red because it received an order which did not work . If I run a command that works , the status indicator stays red and does not refresh the new state "Connected" ok

bartbutenaers commented 4 years ago

Hi Chris, Do you have an example flow to reproduce this? Tried to inject an unknown command into a couple of Onvif nodes, but I cannot reproduce it:

Bart

SuperNinja73 commented 4 years ago

I could not tell you what is the payload which puts the node in default. On the other hand, on this example:

if I ask for a function that works: "Get nodes" the status is green and I have an answer
but as soon as I ask for a function that does not work for my camera: "Get configuration options" for example, the status is red failed.
When I ask "Get nodes" again, I have an answer, but the status is still red, it does not go back to green.

bartbutenaers commented 4 years ago

Chris, Indeed the status was not being reset after an error. But the problem is that I should reset to the current status after x seconds, which might have been changed meanwhile (which makes it difficult to implement). Moreover there was an discussion some time ago temporary node statuses, which unfortunately was a dead end for temporary node statuses.

So for both reasons, I now don't show the temporary nodes statuses anymore (i.e. it keeps being e.g. connected). But instead I use node.error to make sure the errors ends up into the debug sidebar:

Does this makes sense to you?

bartbutenaers commented 4 years ago

@SuperNinja73, Is this ok for you?

SuperNinja73 commented 4 years ago

@SuperNinja73, Is this ok for you?

@bartbutenaers : yes it's ok for me