Invalid handling xAddress with port

bartbutenaers / node-red-contrib-onvif-nodes

Node Red nodes for communicating with OnVif compliant IP devices

Apache License 2.0

67 stars 25 forks source link

Invalid handling xAddress with port #2

Closed av1024 closed 5 years ago

av1024 commented 5 years ago

Nothing worked if I pass xAddress as IP:Port. After digging a while I found it:

onvif.Cam options uses hostname and port for configuration, but in config node there is simple assign options.hostname = this.xaddr

Solution 1 (as I did on local copy): add extra config parameter 'xport' and assign to options.port
Solution 2: parse passed xaddress string for ':' and extract port number from it

av1024 commented 5 years ago

Oops! Looks like all done in git, but not on npm. Close.

bartbutenaers commented 5 years ago

Hi Alexander, Thanks for the analysis!

Unfortunately I have no time for Node-RED this week, but do you mean the code on Github is working, and the one on NPM not? Thought I had published all my changes before I left...

P.S. If you have other feedback, please let me know here or in the discussion on the forum (see link in readme file). Bart

av1024 commented 5 years ago

Hi! I don't tested current git code, but just looked at onvif_config.html here and found the 'port' option already added. So only npm repository is unsync with git.

No more feedback for a week or more. Unfortunately my cheap China's PTZ camera looks so buggy and I temporarily stop trying to make it work :( Next time it will be PTZ preset support digging