search

bartbutenaers / node-red-contrib-sse-client

Node-Red node to receive Server Sent Events
Apache License 2.0
16 stars 6 forks source link

Fix reconnection timeout and possible memory leak #5

Closed Supergiovane closed 2 years ago

Supergiovane commented 2 years ago

There was a little issue in the reconnection timeout. If the server was down for some reasons, the timeout could fail to restart the connection. Fixed. A little memory leak has been fixed. Bumped version to 0.2.4

bartbutenaers commented 2 years ago

Hi @Supergiovane, Thank you very much for your analysis and implementation of the fixes. Will review now and ask for (minor) changes. Bart

Supergiovane commented 2 years ago

Hi Bart i’ve done the changes you requested If there are others i must do, let me know. Just as info, are you using any of my nodes?

bartbutenaers commented 2 years ago

Hey @Supergiovane, Seems good. I have received - in all the years that I do open-source developments - very few pull requests, so it is highly appreciated!!!

No I have to admit that I don't use any of your nodes. Don't have knx, sonos, ... But I also have to admit that I am spending most of my free time to developing in Node-RED, so I have nearly no time left to build flows. So my flows are rather basic, with not much extra nodes installed...

BTW we go this summer to Italy. We have been there already lots of years in a row, and we really love your country!!

Supergiovane commented 2 years ago

Hi Bart Thank you! I also never got someone making a PR. Only users pretending and asking any possible change, without even say “hello” nor star a node. As for your vacation, this year seems better than 2021. All our hotels, restaurants etc. are waiting for guests and are ready to offer a wonderful and covid free sun. Personally, my wife and me this summer, are going to Tuscany, to Sardegna and in our beautiful mountains in Madonna di Campiglio. If you comes around, let me know! :-)

bartbutenaers commented 2 years ago

We have been twice to Tuscany, but this year we will go to the area of Milan. I will put your holiday vacation destinations also on my todo list. My god this must be the most off-topic pull request conversation ever in the history of Github ;-) See you around!

BTW Version 0.2.4 is now available in the palette:

image

Supergiovane commented 2 years ago

Hi Bart Thank you for merging the PR and to trust in my code knowledge. I live 80Km far from Milan and often i go there with my wife, in the shopping streets :-) Again, thanks and nice to have meet you.