search

bartekmotyl / simple-video-cutter

Windows-based tool for efficient browsing and cutting video footage
MIT License
320 stars 42 forks source link

popup preview area is freeze unexpectedly #47

Closed the-liquid-metal closed 2 years ago

the-liquid-metal commented 2 years ago

after several click on timeline and toolbar, popup preview area is freeze unexpectedly.

bartekmotyl commented 2 years ago

This a know issue. I mean - I have seen this few times, but I have no reliable replication procedure in order to debug it. If you can provide one it would be great.

bartekmotyl commented 2 years ago

I have done some improvements in version 0.20 and the problem should be gone...

bartekmotyl commented 2 years ago

fixed in development branch, will be included in next release

0lm commented 2 years ago

this bug seems to be back. how to reproduce: move mouse cursor fast over the timeline. eventually it will quickly freeze on a random frame.

when i moved mouse slow and very carefully, it doesnt seem to freeze. but when you do it a bit faster (and this happens often, since you want to check frames quickly for the right timestamp) then it eventually freezes when you move mouse too fast around the timeline.

bartekmotyl commented 2 years ago

Thanks for reporting, I was also able to reproduce the issue (not easily though).

bartekmotyl commented 2 years ago

I have just committed another approach to fix this problem - debounce updates of the preview (with 100ms delay). Looks promising on my machine. I will include the fix in next release.

0lm commented 2 years ago

Thanks for reporting, I was also able to reproduce the issue (not easily though).

After thinking a little bit about what you replied here and testing things myself, I understand now why you said "(not easily though)".

I tested (on v0.24) different videos of mine, including the one where it happened very easily and alot. Conclusion: other videos I tested it was really hard to reproduce this same bug. Not sure why. But evetually after a longer while, other videos also finally froze. Then I tested the other video again, where it happened alot, and it could be reproduced very easily on it, it froze imediately when moving mouse a bit too fast.

I guess it has to do with some certain specs videos can have, so it was harder for you to reproduce it.

But testing again with v0.25, the results were: it didnt even freeze anymore with the one video, that was really easy to make freeze, thank you!

bartekmotyl commented 2 years ago

Thank you very much for the feedback, @0lm ! I hope the bug is gone now.