Improved workflow (auto-create directories, quick save to sub directories, move/delete original file)

bartekmotyl / simple-video-cutter

Windows-based tool for efficient browsing and cutting video footage

MIT License

317 stars 42 forks source link

Improved workflow (auto-create directories, quick save to sub directories, move/delete original file) #97

Open l3if3rik opened 1 month ago

l3if3rik commented 1 month ago

That's basically all the stuff I developed in several branches on my fork. While your program is the best for my purposes, it lacked some features that I really needed.

Optionally auto-create missing directories
Optionally show a dialog that allows you to save into one of nine sub directories, just with a button click or key press. I missed that, because only after having selected a cut, I know, if it is some action scene, a dialog, whatever. You can guess from the screenshot that it is especially useful for game recordings.
Optionally delete or move the original file after the task was processed. If it is moved, the target can be an absolute directory or a sub directory of its original path.

I do not know how to work with translations, so it is all hard-coded English, currently.

To clarify this further, here are some screenshots:

SimpleVideoCutter_bZj9MTygpA

SimpleVideoCutter_Dy8zstGthE

SimpleVideoCutter_paemkTt8wX

bartekmotyl commented 1 month ago

Thank you very much for submitting! I am currently a bit busy but will try to review as soon as possible.

bartekmotyl commented 1 month ago

I have take a first look at the changes and posted some comments (I reviewed only a subset of changes so far, but already wanted to give feedback). I like the ideas very much, but I would really prefer to have separate submission for each of the concepts (at least for auto-creating directories, quick-save folders, post-processing actions), that would really simplify the review and allow to integrate some changes whilst still discussing others. The first two (auto-creating directories, quick-save folders) seem very useful and straightforward so I would like to integrate them quickly. The third idea (post-processing actions) also looks very good, but there are some conceptual and architectural difficulties (see details in comments I posted). Moreover, currently (at least for me), SVC just crashes when trying to start cutting.

Anyway, thanks again for taking the effort and posting your changes!

l3if3rik commented 1 month ago

Thanks for taking the time to review all that! And sorry for the PR containing so much stuff. Initially, I was just tinkering around (it's been at least 10 years since I developed with .NET) and didn't even think of making a PR.

l3if3rik commented 1 month ago

I will probably address the issues next weekend.

l3if3rik commented 1 month ago

I would consider adding also a "cancel" option, that would mean the action is not constructed and the file is not being deleted.

Except for this, everything should be resolved now.

UnloadVideo() can be used now with an unload/close button that would have to be added.

bartekmotyl commented 1 month ago

Hi @l3if3rik, just a short update from my side - I have seen you pushed lot of changes, but unfortunately I am very busy recently (plus vacation season) so had no time yet to review, and may still need some time to do it. Sorry for the delay and thanks for you effort!

l3if3rik commented 4 weeks ago

https://github.com/bartekmotyl/simple-video-cutter/blob/2618a7cb3fe7da9d6e3b837f976ea615ba34a45a/src/SimpleVideoCutter/MainForm.cs#L775

This bug flew under the radar for quite some time. The files in videoFileArr have their native mixed case names. The filename being searched is lowercase. I fixed that by doing a case-insensitive search like in GetNextPrevFileInDirectory().

A method like GetCurrentFileIndex() would remove redundancy. It would not have a filename parameter, but use fileBeingPlayed. It would fit in, if GetNextPrevFileInDirectory() also dropped its argument currentFilePath (it's not needed right now).