barterli / barterli_android

android app for barter.li
Apache License 2.0
40 stars 25 forks source link

Import to Android Studio #85

Closed imran0101 closed 10 years ago

imran0101 commented 10 years ago

I imported the project to Android Studio.

Using gradle for greater good. Now the folders and packages do not seem to aligned well. All external libraries moved to a single libraries folder.

Gradle using one line import for libraries: File

Picasso ActionBarPullToRefresh (Now Deprecated) Crouton Crashlytics and more ...

Check the PR #88

Let me know on your thoughts.

I will create a pull request if the team is comfortable with Android Studio.

vinaysshenoy commented 10 years ago

We were actually planning to switch to Android Studio pretty soon, and to use Maven for managing dependencies and remove whatever library .jars we can. This looks great!

If you could send a pull request our way, that would be awesome. I'll set up a branch later tonight called android-studio-migration and comment here when it's ready for you to initiate the pull request. :-)

On Wed, Jun 25, 2014 at 9:43 AM, Imran notifications@github.com wrote:

I imported the project to Android Studio.

Using gradle for greater good. Now the folders and packages do not seem to aligned well.

Gradle using one line import for libraries: Picasso ActionBarPullToRefresh (Now Deprecated) Crouton Crashlytics and more ...

Check the branch here. Import/AndroidStudio https://github.com/mipreamble/barterli_android/tree/import/androidstudio

Let me know on your thoughts.

— Reply to this email directly or view it on GitHub https://github.com/barterli/barterli_android/issues/85.

Vinay S Shenoy Professional Android App Developer, Amateur Game Developer +91-9538122356 | vinaysshenoy@gmail.com LinkedIn : http://in.linkedin.com/in/vinaysshenoy

imran0101 commented 10 years ago

Cool.

I'll create a pull request. Please make sure that the team is ready to make a switch.

I'll create a PR in my fork repo. Should be visible to you on this repo.

vinaysshenoy commented 10 years ago

Yes, sure. That's why I want it in a separate branch from development so we can merge it into development when the team is ready to switch.

On Wed, Jun 25, 2014 at 12:41 PM, Imran notifications@github.com wrote:

Cool.

I'll create a pull request. Please make sure that the team is ready to make a switch.

I'll create a PR in my fork repo. Should be visible to you on this repo.

— Reply to this email directly or view it on GitHub https://github.com/barterli/barterli_android/issues/85#issuecomment-47067445 .

Vinay S Shenoy Professional Android App Developer, Amateur Game Developer +91-9538122356 | vinaysshenoy@gmail.com LinkedIn : http://in.linkedin.com/in/vinaysshenoy

imran0101 commented 10 years ago

@vinaysshenoy Check the PR #86 .

I have updated some of the code. Please test it. You can assign me any issue related to the migration.

Make sure you have the latest code merged to master soon. I'll update the migration accordingly.

Lots of files have moved. Can cause an issue. With PR everyone should get in sync.

vinaysshenoy commented 10 years ago

Hey Imran,

master is not used for active development. master points to whatever version is currently on the Play Store and we don't touch it directly.

development is done on the development branch. But even then, I don't want to accept a breaking change on a current branch.

I will refork the development branch into a new android-studio branch. Please pull that, do the Android Studio migration there and give a Pull Request. We will stop development on the development branch, and then merge the Android studio branch when we are ready to shift.

On Wed, Jun 25, 2014 at 1:26 PM, Imran notifications@github.com wrote:

@vinaysshenoy https://github.com/vinaysshenoy Check the PR #86 https://github.com/barterli/barterli_android/pull/86 .

I have updated some of the code. Please test it. You can assign me any issue related to the migration.

Make sure you have the latest code merged to master soon. I'll update the migration accordingly.

Lots of files have moved. Can cause an issue. With PR everyone should get in sync.

— Reply to this email directly or view it on GitHub https://github.com/barterli/barterli_android/issues/85#issuecomment-47071204 .

Vinay S Shenoy Professional Android App Developer, Amateur Game Developer +91-9538122356 | vinaysshenoy@gmail.com LinkedIn : http://in.linkedin.com/in/vinaysshenoy

imran0101 commented 10 years ago

@vinaysshenoy No problem.

I want to get into working of the core issues of the application pending once moved to Android Studio. Although I am uncomfortable with working on Eclipse. I'll see if I can get some work.

The faster the switch the better. Let me know if you have a deadline. It is best to have all issues closed and all branches merged before switching to a complete different environment.

Thanks.

vinaysshenoy commented 10 years ago

Done. I've updated the Pull request. Soon would be good. Development would be slow the next two days due to I/O 2014. If we can migrate it over to Android Studio by Friday, that would be awesome. :-)

imran0101 commented 10 years ago

@vinaysshenoy Just put a message here and I'll migrate the latest development brach to android studio.

Currently I migrated it from master. The latest the better to avoid conflicts. Friday should be done. I believe their is going to be an Android Studio announcement this IO. Also volley.

vinaysshenoy commented 10 years ago

The latest branch is currently development. We always merge development into master, never the other way around.

Please migrate from android-studio-migration instead. That has been freshly branched from development. Once the migration is over and fully tested, we'll merge it into development and begin activie development again.

On Wed, Jun 25, 2014 at 8:46 PM, Imran notifications@github.com wrote:

@vinaysshenoy https://github.com/vinaysshenoy Just put a message here and I'll migrate the latest development brach to android studio.

Currently I migrated it from master. The latest the better to avoid conflicts. Friday should be done. I believe their is going to be an Android Studio announcement this IO. Also volley.

— Reply to this email directly or view it on GitHub https://github.com/barterli/barterli_android/issues/85#issuecomment-47115573 .

Vinay S Shenoy Professional Android App Developer, Amateur Game Developer +91-9538122356 | vinaysshenoy@gmail.com LinkedIn : http://in.linkedin.com/in/vinaysshenoy

imran0101 commented 10 years ago

Dev branch has been merged for Android Studio #87

Merge conflicts with master persists. Any issue related to Android Studio and gradle build. Let me know.

Should I ignore the gradle folder and files?

vinaysshenoy commented 10 years ago

Yes, leave the gradle folder in.

Can you rebase your commits instead? This will merge your commits above the development commits so that merge conflicts can be resolved from your end. You will probably need to close the pull request and do a fresh pull of android studio to do a rebase instead.

On Thu, Jun 26, 2014 at 3:07 AM, Imran notifications@github.com wrote:

Dev branch has been merged for Android Studio #87 https://github.com/barterli/barterli_android/pull/87

Merge conflicts with master persists. Any issue related to Android Studio and gradle build. Let me know.

Should I ignore the gradle folder https://github.com/mipreamble/barterli_android/tree/android-studio-migration/gradle and files?

— Reply to this email directly or view it on GitHub https://github.com/barterli/barterli_android/issues/85#issuecomment-47162272 .

Vinay S Shenoy Professional Android App Developer, Amateur Game Developer +91-9538122356 | vinaysshenoy@gmail.com LinkedIn : http://in.linkedin.com/in/vinaysshenoy

imran0101 commented 10 years ago

Yes. I see the issue.

I'll rebase the whole project and see what can be done.

imran0101 commented 10 years ago

@vinaysshenoy #88 should have the updated commits. I took the opportunity to update to the recently launched SDK version 20 and build tools 20. using Android Studio Beta(0.8.0).

I tested the application. Also resolved a few issues. Let me know if you face any more issue.