search

barterli / barterli_android

android app for barter.li
Apache License 2.0
40 stars 25 forks source link

Ui home #96

Closed imran0101 closed 10 years ago

imran0101 commented 10 years ago

AutoFit the GridView items.

This allows us to tackle the issue with various screen sizes.

Removed ActionBarPullToRefresh.

Added few more Logger methods.

Logger.d(TAG, "just this message");
Logger.e(new Exception());
Logger.e(TAG, "Some Exception", new Exception());

Log is pushed to Crashlytics as well.

Home Screen Image (Before and After gridview spacing) home

Profile Books Screen Image (Before and After gridview spacing) profile_books

vinaysshenoy commented 10 years ago

Looks good except for the changes to the Logger class.

There was a reason we were passing the TAG to the Logger in every call. In the case of using Proguard, the class name could get obfuscated and the Log tag will be useless. That's the reason we were hardcoding the String in every class and passing it to the Log call instead of using getSimpleName. Could you please revert the commits related to those?

Once more thing. Check BuildConfig.USE_CRASHLYTICS flag for true before trying to log crashlytics since we don't want it logged for debug builds and only for Production builds.

imran0101 commented 10 years ago

@vinaysshenoy : I made the changes mentioned above and pushed.

I would like you to remove the landscape and tablet layout for home and test it.

vinaysshenoy commented 10 years ago

Great. I'm occupied right now. I'll test it tonight.

On Sat, Jul 19, 2014 at 7:29 PM, Imran notifications@github.com wrote:

@vinaysshenoy https://github.com/vinaysshenoy : I made the changes mentioned above and pushed.

I would like you to remove the landscape and tablet layout for home and test it.

— Reply to this email directly or view it on GitHub https://github.com/barterli/barterli_android/pull/96#issuecomment-49510135 .

Vinay S Shenoy Professional Android App Developer, Amateur Game Developer +91-9538122356 | vinaysshenoy@gmail.com LinkedIn : http://in.linkedin.com/in/vinaysshenoy