search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Add feature to "lock" certain items in a multi-item trade #125

Open Tecfan opened 4 years ago

Tecfan commented 4 years ago

What problem does this feature address?

This feature will address the problem of the other user selecting games they should not be able to select in a counter offer. See the following example:

You get a 1:1 offer for a game. You feel that your game is worth more, and therefore you would like the other party to add a cheap giveaway game to the deal to make it a 1:2 trade. You counter the offer and add a bunch of cheap games to the trade (because it makes it more likely for the other party to accept) and you select 1:2 trade and send. Now they opposing party can select two cheap $0 games for your paid game [continues below]

Describe a solution

Instead we should be able to "lock" certain games in a trade. So it's a 1:1 trade PLUS 1 other item. The game of your choosing should be automatically selected and impossible to de-select for the other party. If they do not like the trade, they have to decline or counter instead of being able to select two games you did not intend them to select.

See the following trade as an example: https://barter.vg/u/49c/o/3392095/

I want to do Nusakana for Mustache Politics Shooter + a $0 game. In practice, he could select two $0 games as a response to my counter and technically he would not be doing anything wrong. It is unclear what my manually written message on top of the trade would be worth in a dispute.

Examples of similar features

Not sure.

Revadike commented 4 years ago

Dupe of https://github.com/bartervg/barter.vg/issues/17

Tecfan commented 4 years ago

Thanks, was quickly browsing through the issues but didn't click this one

bartervg commented 4 years ago

There is a required option for offer items, but never released it. Offers are still too complicated and people continue to have problems with setting n:n with anything beyond 1:1. Turning on required (and combo) could result in convoluted logic puzzles.

I could turn it on, but would need to send to other testers only. Also would need to check that the JSONs and alerts work.

Tecfan commented 4 years ago

Have been beta testing this for a while now, and it works great, although it needs some GUI work. It has been very useful to me when adding extras to a trade. Hopefully it can be implemented fully one day.

Tecfan commented 4 years ago

This feature can be turned even more advanced, like offering several "sub-bundles" in a trade. For example, I offer you:

Group A ---> Game 1 ---> Game 2 ---> Game 3

OR

Group B --> DLC 1 --> DLC 2 --> DLC 3 --> DLC 4 --> DLC 5 --> DLC6

OR

Group 3 --> Game 1 --> DLC 5 --> DLC6

OR

Group 4 --> Game 1 --> Game 2 --> Game 4

etc.

And those sub-groups can be connected to similar groups at the side of the other trader.

woutercools commented 3 years ago

I just finished a trade with Tecfan and I was pleasantly surprised by this "lock" feature in his offer. For months I was hoping I could make such offers. He told me this feature is in beta.

I hope it will be released soon.

bartervg commented 1 year ago

This feature can be turned even more advanced, like offering several "sub-bundles" in a trade.

This is called combo, but there is no UI implementation (hidden or visible).