bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Better search function #143

Open Tecfan opened 4 years ago

Tecfan commented 4 years ago

What problem does this feature address?

Making a general github issue to address the search functionality as it could be better. I could not find another issue for this using the search function on github (I searched for "search").

As a "power user" of barter.vg, I've noticed many times that the search function does not always produce the results I want. I have not been tracking this, but I am now making this issue and will update it as I find issues.

The most common issue is that the search function does not find items where just 1 letter is missing.

Examples: Searching for Asset Flip Simulator + 4 DLC does not find the item Asset Flip Simulator + 4 DLCs. Searching for division 2 finds the correct game on Steam, but not on any other platform. Why?

I'll continue to add more examples as I find them.

Describe a solution

Better search

Examples of similar features

bartervg commented 4 years ago

If + or - are in the query, that activates BOOLEAN MODE which produces different results Asset Flip Simulator 4 DLC vs Asset Flip Simulator + 4 DLC In addition, results are ordered by platform and therefore packages are at the bottom of the Steam results. However, I can add Asset Flip Simulator + 4 DLC as a title match and that leads to a direct match redirect.

Here's the logic:

bartervg commented 4 years ago

In natural language mode, division 2 is equivalent to searching division which is why B.A.D Battle Armor Division has the same relevance as Tom Clancy's The Division 2. Therefore, it's difficult to match division 2 when it isn't the exact match title.

I added a specific query for non-Steam only. This will ensure that Steam results don't push them off the page. This revealed 2 The Division 2 Epic Game profiles.

Tecfan commented 4 years ago

Thank you for the explanation. Can you keep this open for some weeks so that I can gather some other examples? They might all have logical explanations, but I know that I had some more weird ones.

Tecfan commented 4 years ago

Here is another example with the + one: image

bartervg commented 4 years ago

What is the exact string? When did you do this search? - Arcane RERaise - +-Arcane preRaise - works alright when I tried image

Tecfan commented 3 years ago

Searching for "Clan of Champions - Gem Pack 1 DLC" (the name Fanatical uses) will not find "Clan of Champions - Gem Pack 1" at all.

https://barter.vg/i/7454/

https://barter.vg/search?q=Clan+of+Champions+-+Gem+Pack+1+DLC https://barter.vg/search?q=Clan+of+Champions+-+Gem+Pack+1

Tecfan commented 3 years ago

Searching for "Abby character pack", would assume that "AnyWay! - Abby character pack!" would be higher up in the search results, the other results are not really that relevant: https://barter.vg/search?q=Abby+character+pack

Tecfan commented 3 years ago

Searched for ife is Strange 2 - Arcadia Bay Patches DLC (L fell out of the paste), and even with all the other words intact, it did not find the DLC – it probably should. https://barter.vg/search?q=ife+is+Strange+2+-+Arcadia+Bay+Patches+DLC

Tecfan commented 3 years ago

I'm unable to find Japanese Indies Bundle (Indiegala) via search. https://barter.vg/bundle/5461/

Tecfan commented 2 years ago

Search for Starfinder Core Rulebook: https://barter.vg/search?q=Starfinder+Core+Rulebook

Expect to find Starfinder Core Rulebook: https://barter.vg/i/123913/

But it does not show up in search results.

Tecfan commented 2 years ago

Search for Ashampoo WinOptimizer 18

Expect to find the item page with the exact same name

Finds nothing.

Should have found: https://barter.vg/i/147289/

Tecfan commented 2 years ago

Same issue with Ashampoo Backup Pro 14

Tecfan commented 2 years ago

Search for HorrorBabble

Expect to find HorrorBabble - Arctic Horror: A Collection (audio book) (Groupees item): https://barter.vg/i/137056/

Instead find: HorrorBabble - Three Philip K. Dick Shorts (Mp3) and HorrorBabble's Ultimate Weird Tales Collection (audiobook) but NOT HorrorBabble - Arctic Horror: A Collection (audio book).

Odd. Are newer weird-platform-items not indexed properly? This also happens with e.g. Mafiosa from the same bundle: https://barter.vg/bundle/5240/

Tecfan commented 2 years ago

Same issue with Astrodogs Demo. Finds nothing, although an exact name match exists. Also a newer item.

Tecfan commented 1 year ago

More indexing issues:

Search for Carto or Carto Demo. No matches for Carto Demo (GOG): https://barter.vg/i/147449/

https://barter.vg/search?q=Carto&f=1

Tecfan commented 1 year ago

Search for Crossing Souls Demo, no matches for https://barter.vg/i/126069/

https://barter.vg/search?q=Crossing+Souls+Demo

bartervg commented 1 year ago

Search for Crossing Souls Demo, no matches for https://barter.vg/i/126069/

https://barter.vg/search?q=Crossing+Souls+Demo

tool, config, media and demo are excluded from the search results. This was a blunt attempt to prevent those types from being accidentally added as tradables.

bartervg commented 1 year ago

2+ years of missed updates

https://barter.vg/search?q=Clan+of+Champions+-+Gem+Pack+1+DLC

Manual fix, added Clan of Champions - Gem Pack 1 DLC as a title to i/7454

Searching for "Abby character pack", would assume that "AnyWay! - Abby character pack!"

Game are prioritized over DLC, It does seem that Abby would be the rarer term, and therefore favored in relevance over character and pack . Relevance score for Abby alternate skin is 4x higher than everything else, I don't know how to fix this.

Searched for ife is Strange 2 - Arcadia Bay Patches DLC (L fell out of the paste), and even with all the other words intact, it did not find the DLC – it probably should.

Arcadia finds it, https://barter.vg/search?q=Arcadia+Bay+Patches+DLC finds it also, but lower in the results. Another I don't know enough about relevance in MySQL MATCH() AGAINST to improve this

I'm unable to find Japanese Indies Bundle (Indiegala) via search. https://barter.vg/bundle/5461/

Every Japanese Indies Bundle was a rebundle of My Better Half Bundle and rebundles were excluded from search results. I've added rebundles to results.

Search for Starfinder Core Rulebook: https://barter.vg/search?q=Starfinder+Core+Rulebook

This works now, but it's the second result under Other Platforms

Search for Ashampoo WinOptimizer 18

This is the only result in Other Platforms. I believe these were excluded due to type. Now there is a low-priority direct-match search without any type (tool, config, media, demo) exclusions.

Search for HorrorBabble

This is another media type exclusion, but where some of the HorrorBabble items were set as Music and thus were not excluded from search results.

Same issue with Astrodogs Demo. Finds nothing, although an exact name match exists. Also a newer item.

Astrodogs Demo will appear now, but as the 11th results. 1st result under GOG.

No matches for Carto Demo (GOG)

Appears now due to the addition of non-type exclusion for non-Steam results

Tecfan commented 9 months ago

Search Doodle God Blitz - Greatest Inventions does not find Doodle God Blitz - Greatest Inventions DLC at all:

https://barter.vg/i/41699/