search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Can create giveaways for items that don't exist in the database #168

Closed bartervg closed 1 year ago

bartervg commented 3 years ago

Describe the bug

Giveaways are associated with a item that has a profile page on Barter.vg. However, it is possible to create a giveaway that links to a 404 page because the item doesn't exist.

Steps to reproduce the bug

  1. Create a giveaway using an item ID that doesn't have a profile yet
  2. Click on the resulting link ()
  3. View 404 error page

Expected behavior

If the item doesn't exist, the giveaway addition should fail and provide an error message why.

Screenshots (if helpful)

image

bartervg commented 1 year ago

This was fixed. The form submits, but this error appears

Invalid Item ID Warning This profile does not exist yet. The giveaway was not posted.

No giveaway posted, no line under Updates, and no Discord alert.