bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Add an "exclude tradeables collection" filter to the browse page #174

Closed Tecfan closed 3 years ago

Tecfan commented 3 years ago

What problem does this feature address?

A need to not see games in a search that you already have up for trade (but not in library).

Describe a solution

Add a "exclude tradeables collection" filter to the browse page.

Examples of similar features

"exclude owned or blacklisted" "exclude owned, blacklisted or wishlisted"

image

bartervg commented 3 years ago

Added exclude tradables. image

Either I do not understand how this was implemented previously, or it was not working correctly. In addition owned was ambiguous and referred to library, or library and tradables. I removed owned and use the collection names instead.

Rather than enumerate every permutation of what to include or exclude, a future browse could have include / exclude for each collection.

Tecfan commented 3 years ago

Since I made this thread, I have temporarily moved all my tradeables to reserve collection, so I cannot used this option after all. Could it be "exclude tradeables and reserve"?

bartervg commented 3 years ago

image

bartervg commented 3 years ago

This seems to work, but the naming of variables was short sighted. It is setup to exclude library, tradables, blacklist or wishlist by passing the collection IDs as function parameters. I could change that to include reserve or use generic names, but I just changed the blacklist collection ID to the ID of the reserve collection.