bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Better clarity for bundle items that have been included twice in the same bundle in different packages / add a non-packaged bundle tag or similar #179

Closed Tecfan closed 1 year ago

Tecfan commented 3 years ago

What problem does this feature address?

Take this DLC: https://barter.vg/i/5793/

It was included in Humble Codemasters Bundle 2015 BOTH as a standalone DLC (tier 1) AND in the tier 3 package "GRID 2 All In DLC Pack".

When an item is included in a package, the following tag gets added on the /i/ page bundle section: image

This tag discourage people who are looking for the standalone item from even opening the bundle page to check the contents. If they did actually open the 2015 bundle, they would find that the "package" tag is very inaccurate (something I found out a couple of weeks later).

Describe a solution

We need better clarity for these types of situations. I don't know how the backend system works for bundle tags, but I assume a "non-packaged" bundle tag needs to be added. Nothing on the item page indicates that it was included twice either. This is also an issue in bundles where you get multiple copies, so a "multiple copies" tag is maybe also needed, see bundles like https://barter.vg/bundle/3409/ and the lack of "x2"/"x3" on the individual item pages.

Examples of similar features

Bundle tags.

Tecfan commented 3 years ago

A second example just came into existence,

Samorost 2 is now both in a package and available as a standalone key in Humble Indie Bundle 2. https://barter.vg/i/3513/

This is not possible to see from the /i/ page:

image

bartervg commented 3 years ago

Fix could address this as well #126

Tecfan commented 3 years ago

New example: Peggle Deluxe is now in 3 different packages in the same bundle, but this is not noted on the game page: image

(what decides which package is linked?)

https://barter.vg/i/10148/ https://barter.vg/bundle/214/

Tecfan commented 2 years ago

See also this post: https://steamcommunity.com/groups/bartervg/discussions/1/1488866813777614422/?tscn=1634075550#c3082142648924997749

The example being: https://barter.vg/i/1368/

image

The game is in both tier 3, and in a package in tier 4.

Barter currently reports "tier 3 of 4", + a package tag. While this is techincally correct, it is also hard to decipher without further research, so more clarity on the game page would be preferred

Tecfan commented 1 year ago

This is again an issue with the Company of Heroes Complete bundle.

https://barter.vg/i/156/

CoH base game listed as a Package, even though it is (also, and foremost) a standalone key.

bartervg commented 1 year ago

The design flaw was the assumption that item-bundle relationships would be unique. When an item is in a bundle more than once, it violates this assumption. These issues are some of the side effects.

Rather than add new tags, I reindexed item-bundle listings on a unique value. This avoids multiple occurrences merged into a single line. The advantage of this change is that the tier information is shown (e.g. tier 1 and tier 3). The disadvantage is that, at first glance, it may appear to be a duplication bug. In addition, bundles appear multiple times where it is not useful.

image

This is fix is incomplete. The bundle tag system continues to rely on item-bundle to be unique. For example, the 400736 subID tag on the tier 1 Company of Heroes is shown on the tier 2 package as well. The latter tag should not appear. Standalone and package has an easier fix, but the better fundamental fix would be ensure uniqueness on bundle tags.

image

The bundle count for Company of Heroes is 8 on the item profile page, 7 on the bundle page. Which is more accurate? It's appeared only once as a standalone game (in Yogcast 2019).

bartervg commented 1 year ago

(what decides which package is linked?)

It was random. It changed on each pageview.

I added order by tier, but then saw that Peggle Deluxe had 3 different packages in the same tier. To ensure the order would not fluctuate randomly, I added order by a unique ID. That ID is determined when added to the bundle. Therefore it essentially orders by when the item added to the bundle.

bartervg commented 1 year ago

so a "multiple copies" tag is maybe also needed,

The multiple copies tag has been available on bundles, but is rarely used. I added it to https://barter.vg/bundle/3409/ and I can see why. The tag is easy to miss and doesn't display the number of copies. Since it's in between other icons such as library and blacklist, it may be confusing to use x icon. image

It's a bit better on the item profile pages. This page shows the number (e.g. number of copies, subID number) for all tags. image

Perhaps the extra copies tag should appear separately from other tags. image

bartervg commented 1 year ago

In addition, bundles appear multiple times where it is not useful.

The bundles, which the related packages are in, no longer appear for the pulldown for the app. Since the app isn't in the bundle as a standalone item, it was misleading to list those bundles.

image

The internal Barter focus group was strongly against the duplicate listings of bundles. The particularly bad example was Company of Heroes 2 with 8 rows for 3 bundles, image and now it is consolidated into 3 rows, image

The bundle tag system continues to rely on item-bundle to be unique.

This was a convoluted fix, but turned up many related errors.

the lack of "x2"/"x3" on the individual item pages.

The tag will appear on the item profile pages if someone applied it on the bundle.

However, this remains a problem for https://barter.vg/i/117/#bundles and for bundles where the same item appears more than once (rather than app and package). The subsequent additions doesn't display tags on the item profile page. I checked most of the 321 items where items appear in a bundle more than once, and nearly all of them were LootBoy or lequeshop. Therefore, no plan to fix this on the item profile pages.