search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

"Move to" function on /i/ pages is not working #185

Open Tecfan opened 3 years ago

Tecfan commented 3 years ago

Describe the bug

Add a tradable, wishlist, watchlist, blacklist, notification, reserve or scratchpad item (doesn't matter which collection or which item/game), and then try to move it using the [move to] function on /item/ pages. It will not work, with no error.

Steps to reproduce the bug

  1. Go to any /i/ page, like https://barter.vg/i/22286/
  2. Add game to a collection, for example "Reserve"
  3. Try to, using the "[move to]" function on the /i/ page, to move the collection item to another collection, for example from "Reserve" to "Tradable"
  4. Observe that nothing happens

Expected behavior

Item is moved.

Screenshots (if helpful)

image

Device (if applicable)

Additional context

bartervg commented 1 year ago

This was due to the emergency bug fix of #68 that allowed for any user to move any collection item. The fix relies of verifying the collection item belongs to a collection that belongs to the user. This works fine on collection pages where everything is from the same collection, e.g. wishlist.

When multiple collections are mixed together, such as on the item profile pages, this verification process doesn't work efficiently hence the multiple forms.