search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Some +extra wishlist items are turned into #-1 (non-functional) after library syncing #197

Open Tecfan opened 4 years ago

Tecfan commented 4 years ago

Describe the bug

image

be me change the wishlist from #-1 to #1 sync profile (library/wishlist) item is automatically turned into #-1 wishlist, even if it is tagged "+extra"

Expected behavior

Item stays at #1 because it is tagged +extra.

Additional context

Not sure what causes this, most items do stay at #1 as long as they are tagged +extra

Tecfan commented 4 years ago

Looks like this happens only if you already have the item in your tradables? I usually want other subID's of tradables and therefore will keep my +extra wishlist. Is the -1 intended?

Tecfan commented 3 years ago

Closing threads: this is due to expected blacklist behavior. I think, at least.

Tecfan commented 3 years ago

Nevermind. This bug happens with non-blaclisted games as well. Re-opening thread.

bartervg commented 3 years ago

be me

For syncs, I did this by modifying the form URL from /a0/ to /49c/ thereby avoiding admin powers usage here.

change the wishlist from #-1 to #1

I found 64 wishlist items that were extra and -1 quantity. I changed Super Monday Night Combat https://barter.vg/i/333/ to quantity 1 (admin powered needed).

sync profile (library/wishlist)

I synced library. No change. I synced wishlist. No change. I synced profile. Quantity goes to -1. This is strange since it's simply combining the sync requests. Looking at https://barter.vg/u/49c/a/ I see wishlist syncs failing (No wishlist data). Therefore, the ability to reproduce the bug may be affected by the wishlist sync failing.

Looking at the code, it's fairly simple and in order for it to set to -1, the type has to != 'extra' so I don't know why it would change a wishlist extra. With a much smaller collection, I added 2 wishlist extras and synced library, wishlist, profile. However, encountered the same wishlist failing activity.