search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Reserve collection in game offers #205

Open Tecfan opened 3 years ago

Tecfan commented 3 years ago

What problem does this feature address?

The reserve collection is very hidden away. I propose some useful functionality:

Describe a solution

When creating offers to other users, you should be able to also see what games you have on your Reserve list, that they have in Wishlist / Unowned / Library. If selected, they will be moved from Reserve to Tradable.

The details (not very thought through): If you have multiple copies in the reserve list, all copies will be moved as well, so that the system does not have to create a "new" tradable, but instead just uses the move function. This preserves your "order" on /i/ pages, so that you appear higher in the tradable list.

Underneath the offer boxes when creating the offer, a checkmark option should appear: "Move extra copies of the tradable back to Reserve collection after completing offer"? or something similar.

Alternatively, go with the simple solution and just create a new tradable, and let the extra copies sit in the Reserve collection. If the offer is declined, delete the new tradable and increment the reserve collection. Notify the user via a brand new notification system(!) – adjusting people's tradables/reserve without their knowledge is bad.

Examples of similar features

bartervg commented 1 year ago

What's the benefit of moving from reserve to tradable?

Tecfan commented 1 year ago

Isn't that the whole point of the collection? You have some stock that you are not interested in trading, but at some point you want to trade them, so you move them from reserve to tradable? I might have misunderstood the Reserve list.

bartervg commented 1 year ago

Shouldn't reserve work like watchlist does in the offer? image There's no need to move watchlist to wishlist. I guess the problem would be when the offer is completed, the watchlist remains?

Revadike commented 1 year ago

Shouldn't reserve work like watchlist does in the offer?

What do you mean by that? Idk but tecfan's idea seems the most sense to me.

bartervg commented 1 year ago

What do you mean by that?

This makes sense to me.

you should be able to also see what games you have on your Reserve list

Whereas,

If selected, they will be moved from Reserve to Tradable.

I'm questioning this aspect of the idea: if selected, then move collections.