search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

If possible, increase the maxlength of JSON import textareas #211

Open Tecfan opened 3 years ago

Tecfan commented 3 years ago

What problem does this feature address?

If possible, increase the maxlength of JSON import textareas. It's currently at 150000 characters, and it's not enough if you import/export large collections.

Describe a solution

Increase the textarea/input max character length

Examples of similar features

bartervg commented 3 years ago

The problem is that a sufficiently long enough input will cause the request to timeout or the server to run out of memory. 150k seemed like a safe limit, but if you want to experiment to find those fail points, I changed it to 500k.

Tecfan commented 3 years ago

I imported 500k char blacklist (almost my entire blacklist) into my alt account. Had no issues, 179 of the items were new.

bartervg commented 3 years ago

Increased to 750k.

Tecfan commented 3 years ago

Could you test 1M? My blacklist export has hit the limit now. 750k has been no issue.

Tecfan commented 2 years ago

My tradable list is now 23 277 items. The JSON export is 922 000 characters, could you try to increase the max limit to 1M?

When importing this list in two parts, several thousand tradables are missing. I want to test if this is also the case with a full import.

The tradables that are missing are "duplicate" tradables, but with different bundle sources it seems. This behavior is unexpected, and I'd like to test it some more.