Include tradables when filtering

[Tecfan]

What problem does this feature address?

When filtering other users' collections, tradables are often not shown. Instead, every OTHER collection is included, but not tradables. Here's an example from me filtering another users' wishlist, to find out what they want from my wishlist (they were unavailable, so could not open an offer):

Describe a solution

Please include tradables when filtering.

Examples of similar features

[Luckz]

You didn't really mention any problem, improvement or benefit. If I understand the intention of the example (replacing your "from my wishlist" with "from my tradables"), it looks like you want to filter your own tradables for another user. That happens on your tradable page, not their wishlist page. I do believe that a quick link to filtering your tradables for a user you are viewing is useful, but that's far unrelated to anything you mentioned here. If that's not the intention, I don't get it whatsoever: why would you want to match your wishlist with their wishlist; why would the offer page (if they weren't unavailable) show games that are on both of your wishlists?

[Tecfan]

As I had all my tradables in my reserve collection, I grew accustomed using other users' wishlist pages to filter things I had, that they wanted. This worked just fine, until I moved everything back to my tradables. I did not realize you could filter inactive users [that they showed up in the dropdown list] from your own tradable page, that kind of solves the problem.

I now also see that tradables DO show up in filters, it's just that my blacklist and library usually "trumps" them. When I had 10k items in reserve, they all showed up in one big list, just like filtering from my own tradable list would have done. It was very quick, easy and would not require me to almost crash Chrome by opening my tradable page lol.

For example, these 4 items that I added to my reserve collection as a test, shows up only in reserve, but not in tradable:

Also, there's some weirdness with "combined" items from my tradable list leaking into my reserve "combined" list.

Conclusion: I grew accustomed to using other users' wishlist page to filter tradables/reserve, because reserve collection is not excluding library and blacklist when filtering on wishlist pages. Now that I know about filtering my tradables for inactive users is possible from my own tradable page, this github issue is no longer of any use, unless I can re-use the post to propose that a "quick link" for filtering my tradables for another users' wishlist would be useful (for active users you would normally use the offer function for this, but for inactive users you can not do this). I can also re-use this issue or create a new one, to tackle the problem of packages leaking into other collections, as happened with the Occult RERaise DLC's in the screenshot.

[Tecfan]

See also #134 for more filtering weirdness.

[bartervg]

I implemented this suggestion as an alternative means of addressing this issue.