search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Counter offer should preserve original quantities #217

Closed bartervg closed 3 years ago

bartervg commented 3 years ago

What problem does this feature address?

When countering an offer, the quantities default to 1 regardless of the original quantities.

Describe a solution

please re-use the quantity numbers when countering an offer with multiple copies of the same game @Revadike https://discord.com/channels/329829406153375755/581243124916158464/799363143238942730

Examples of similar features

Quantity is easily overlooked and this is a source of disputes. The counter should be identical to the original until edited.

bartervg commented 3 years ago

Surprisingly, the addItem() method public function addItem($side, $item_info) didn't have a quantity parameter. $quantity = 1 was hard coded except for trading cards, gems, and refined metal, which were set to 0. Now, the quantity values are passed in from the countered offer.

TODO: required and combo values should be passed in also, if / when these become fully implemented.

bartervg commented 1 year ago

125

TODO: required and combo values should be passed in also, if / when these become fully implemented.