bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Apps included in Steam packages link to /sub instead of /app #221

Closed bartervg closed 3 years ago

bartervg commented 3 years ago

Describe the bug

Because the apps included in packages are treated as packages, the link is incorrect. This may have been hardcoded in order to ensure ordering $result[$platform][$i]['platform_id'] = 2;

Steps to reproduce the bug

  1. Go to a Steam package on a collection page, e.g. Tradable
  2. Expand the included games
  3. Click on the open in a new tab link arrow, see /sub/ instead of /app/

Expected behavior

The link should go to the app page since it is using the appID

Screenshots

image

Additional context, device information (OS & Browser) if applicable

Reported by zioomxD, screenshot by arseny92 https://discord.com/channels/329829406153375755/329829406153375755/804103530989486112

bartervg commented 3 years ago

A proper fix would be to use the accurate platform ID of 1 instead of 2 (1 = app, 2 = package). However, likely that would have side effects.

Instead used /app/ link if platform 1 or included in package. This might cause problems with hypothetical Frankenstein's monster packages within packages, but those shouldn't exist.