search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

> Incrementing quantity when adding from the bundle page #223

Open bartervg opened 3 years ago

bartervg commented 3 years ago

Currently, the quantity isn't even incremented when clicking the Add new tradable button.

Incrementing quantity when adding from the bundle page is one of my pet feature requests of many years ago that doesn't even have a GitHub issue. (When I want to add tradables from a second bundle copy, I have to do/adjust this manually for each game that will have more than one identical tradable in the end, to get the quantity right.)

Originally posted by @Luckz in https://github.com/bartervg/barter.vg/issues/182#issuecomment-769747257

bartervg commented 3 years ago

image image

Tecfan commented 3 years ago

So is this "3" tradables or "+3" tradables from that specific bundle? Sometimes you buy a bundle for a second time later again when some of the games might already be traded, so would be good to have that clarified.

bartervg commented 3 years ago

So is this "3" tradables or "+3" tradables from that specific bundle?

The former. It sets the quantity to 3 if the tradable didn't previously exist. If adding for a second time, you should receive a Failed update attempted, but nothing appears to have changed error message.

However, it does highlight the games, which should make it easier to highlight. I didn't test more than 2 tradables of the same game. It's possible that the incorrect tradables will be highlighted. It may have been by chance that the correct versions were selected when I tested it.

Instead of a number input, I could change it to a select menu that had 3 and +3.

Luckz commented 3 years ago

Now it's thus have to adjust this manually for each group of games that will have more than one identical tradable in the end, to get the quantity right?