search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Time limit for completing or failing an offer #226

Open bartervg opened 3 years ago

bartervg commented 3 years ago

What problem does this feature address?

Offers expire if the side to act doesn't do anything, except if one side failed or completed an offer. In this state, the offer remains neither expired or failed or completed indefinitely. This keeps years old offers classified as active. In addition, this encourages retraders to leave offers open and wait until the retrade is successful before completing the original offer on Barter.vg, essentially requiring the other side to provide an indefinitely long warranty.

Describe a solution

As with other offer states, require action within a limited period of time. If the side does not act, set to a final neutral option. There could be an option to complete the offer later, but not dispute it other than if the key was revoked from the library.

Examples of similar features

Proposed and accepted offers expire if not acted upon and this state is final. The same logic of that should apply to partially completed or failed offers. If one side doesn't act on an offer for weeks (months and even year), it should not remain active.

lillje commented 2 years ago

An additional issue is that offers that are not completed by the other party remain stuck to the top of the list even after years, for example: https://barter.vg/u/ab/o/ (waiting for a status from volcanopunk after failed offer 6 months before, waiting for a status from darktrop11 after cancelled offer 3 years before)

MarcovonSchmidt commented 2 years ago

I'm the user with that issue above. Would be very nice if this gets a solution in the future. If I get more trades with such states, I have to scroll a lot for my newest completed or declined trades. No reaction from the other side within 30 days, should close the trade automatically, with a neutral automatic answer from the not reacting side. Thank you

remiliacn commented 1 year ago

+1 to this ticket. I have an offer that I marked as completed 5 weeks ago, and the other party has not yet marked it as completed.

I understand people may take some time to complete an order, me myself included, but the longest I wait was 3 days, even that, it is not done by bad intention, it is just me forgetting it. But I do believe an expiration that set to 4 weeks (1 month) should be reasonable.

Here is the offer that I am pointing to. Implementing this logic could also prevent bad actors to maliciously leave an offer active for as long as they want to resell their key. As far as I know, when a key is traded, the key should be activated immediately, and if the key has an expiration date, this seems to hurt the good actor more as the bad actor can easily file a complaint, and the complaint could hurt good actor's future trades.