bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

+1 marker for games that increment game count on profile #232

Closed d4rckh closed 3 years ago

d4rckh commented 3 years ago

What problem does this feature address?

This would tell people if a game increments the game counter by 1 on the steam profile (also known as +1)

Describe a solution

A small button on game page which upon pressing it, the user reports the game as giving +1.

This would be soooo useful as a lot of people's question is "does this game give +1?".

antigravities commented 3 years ago

Games that count as +1 are not banned (⎚ in offers/on item pages) and not profile limited (⚙️ in offers/on item pages). You can also trivially determine whether a game counts towards your profile's number if the Store page does not contain the "features" "Profile Features Limited" and "Steam is learning about this game." There is also a tag marking games that add to game count, but tags on item pages sometimes appear to be incorrect or outdated.

bartervg commented 3 years ago

231

bartervg commented 3 years ago

As antigravities mentioned, the Steam plus one tag exists and can be browsed at https://barter.vg/browse/tag/531/ image Would you recommend making it more visible somewhere else on the page?

As at least one person has reminded me, the major limitation of the +1 tagging system is that Steam determined +1 by the subID, and the game profiles on Barter.vg are appIDs (for the most part). For example, a game could go from paid to free on demand. Anyone that purchased the game should get +1, anyone that adds the free on demand version won't.

d4rckh commented 3 years ago

when choosing games to trade with someone, there could be a little +1 marker.

Revadike commented 3 years ago

I can imagine this enables the trade preference of only accepting +1 games, which would be pretty nice.

Luckz commented 3 years ago

I can imagine this enables the trade preference of only accepting +1 games, which would be pretty nice.

The tag is there already, but we need to determine if it's applied correctly. Like, how do we find edge cases of what gives +1 and verify the tag is applied correctly, and functions correctly for all variations of decom products? We might also want "plus-more-than-one" support, for tradables that give you several entries.

At least DLCs also have the distinction between +1 (tracked via profile count) and +0 (does not increment profile DLC count), eh?

As at least one person has reminded me, the major limitation of the +1 tagging system is that Steam determined +1 by the subID, and the game profiles on Barter.vg are appIDs (for the most part).

Outside of curator trades, which are not exactly the target group in the first place, a traded copy should always "+1 as much as possible", since you can't trade a Free on Demand item. So for purposes of trade preferences, it's enough if any +1 version could exist, and you filter out curator tradables. We don't have access to an automated system to determine which games' curator versions would be +1-qualified. I mean, I guess if the developer changes a Store package to a FoD package, you might have a FoD key? And perhaps that's not a +1 then, while it was before (as Store / Retail) or is with other packages.


Some research:

GameMaker: Studio https://barter.vg/i/4581/

Luckz commented 3 years ago

Also, don't forget to consider non-game things that yet give "game" +1. I guess make available to trade to someone who wants +1s?

bartervg commented 3 years ago

This is the logic from plus_one_tagging.php translated into English

Steam platform AND game, application, mod AND NOT S-T Test App, F2P (unavailable), Delisted video, Free software, Unreleased software, Banned AND NOT Steam profile limited AND NOT is_free OR is No Cost AND NOT adult OR is tagged Steam plus one AND NOT tagged free on demand AND NOT tagged Steam plus zero fix AND NOT is_free OR is Steam-Tracker Delisted, Purchase disabled, Retail only OR No Cost

edit: Steam plus zero is different from Steam plus zero fix. The former is automatically applied to help with browsing and the latter is manually applied in order to force +0 and remove +1.

bartervg commented 3 years ago

https://github.com/bartervg/barter.vg/blob/develop/data/playtests.txt

I added Steam plus zero fix to all of them. Some of them didn't count as +1 already, e.g. https://barter.vg/i/118820/ due to Steam-tracker Test app

d4rckh commented 3 years ago

I remember there being a giveaway with some keys that would activate a package with 2 games (both +1 but one of them did not have a store page)

https://steamdb.info/sub/33026/info/

bartervg commented 3 years ago

image This +1 tag appears on the offer page, in the place where the ⚙️ Steam Limited tag would appear. image

It shown when selecting games for an offer also image

Again, it's an estimation based on an ad hoc model. Looking at luckz's library https://barter.vg/u/427/l/ Steam Games Owned: 15607; Barter Estimation: 15454, shown as the estimation error of (153 ε) (probably makes more sense if it were negative). Since this is the net difference, it's possible there are more than 153 inaccuracies.

The +1 system is a long-term upgrade, but I believe this issue is completed.

Revadike commented 3 years ago

do curator games give +1?

Revadike commented 3 years ago

do curator games give +1?

@bartervg @Luckz

bartervg commented 3 years ago

do curator games give +1?

Isn't this a SteamDB question? Although, I think at this point after any pre-DisableGameCount packages have expired, the answer is no.

Revadike commented 3 years ago

Most, if not all, curator connect packages from 16 months ago and newer have this: image

Therefore, I suggest hiding the +1 tag for tradables tagged as curator connect games.

bartervg commented 3 years ago

Therefore, I suggest hiding the +1 tag for tradables tagged as curator connect games.

Before change image After change image image

Revadike commented 3 years ago

@bartervg why does this not count as +1: https://barter.vg/i/8726/ ? Because it does. I tested it.

Luckz commented 3 years ago

@bartervg why does this not count as +1: https://barter.vg/i/8726/ ? Because it does. I tested it.

Free licenses are listed as plus zero: NOT tagged free on demand AND You can of course own a free game, and if it's not PFL or such it will be +1 then. We don't have a good way of marking this in your library collection either (believe me, I tried a few). Of course maybe since we're still foremost a trading site, there's the case that we shouldn't list FoD games as +0 unless they're also PFL because tradables will be +1. But if we change that, I'm sure there will be some users complaining that they claimed the free license and did not get a +1, and to make matters worse there are various exotic free licenses that DO give a +1 for more or less understandable reasons. https://www.steamgifts.com/discussion/fZdnc/free-steam-games-that-add-1-to-steam-games


PFL = Profile Features Limited (or Steam is Learning ...) FoD = Free on Demand

Revadike commented 3 years ago

PFL?

Revadike commented 3 years ago

License 'Offworld Trading Company - Free Multiplayer' is not free though. It has billing type CD key. Also, it's included app is not free.