bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues

https://barter.vg

MIT License

20 stars 4 forks source link

Game Pass for PC has broken links #246

Closed Revadike closed 3 years ago

Revadike commented 3 years ago

Describe the bug

Item Game Pass for PC displays a steamdb icon, linking to https://steamdb.info/app// As well as a broken ITAD link.

Steps to reproduce the bug

Trivial

Expected behavior

Don't show broken icons.

lillje commented 3 years ago

I can't see the SteamDB icon that you mention, does it maybe come from a userscript?

At the moment, ITAD links are generated based on the item title and sometimes that item doesn't exist on ITAD. Any idea how to check if an ITAD link is valid or not? For example, Game Pass for PC does not exist as an item, but 3 Months Xbox Game Pass for PC does.

Revadike commented 3 years ago

I can't see the SteamDB icon that you mention, does it maybe come from a userscript?

I thought I saw it on the item page too, but you can still see it in an offer page, for example: https://barter.vg/u/48e/o/3978877/

At the moment, ITAD links are generated based on the item title and sometimes that item doesn't exist on ITAD. Any idea how to check if an ITAD link is valid or not? For example, Game Pass for PC does not exist as an item, but 3 Months Xbox Game Pass for PC does.

Maybe https://api.isthereanydeal.com/v02/search/search/?key=<APIKEY>&q=<QUERY>

bartervg commented 3 years ago

I thought I saw it on the item page too, but you can still see it in an offer page, for example: https://barter.vg/u/48e/o/3978877/

ITAD links are generated based on the item title

At least for Steam apps, the links are based upon https://api.isthereanydeal.com/v01/game/plain/id/?shop=steam&ids=[appids] (itad_plains.php cron)

but 3 Months Xbox Game Pass for PC does.

I changed the ITAD link on the profile page

bartervg commented 3 years ago

SteamDB links shouldn't appear for any item that is not appID or subID. If you find an example, try disabling all plugins and reloading the page. If it is still there, (small) bug bounty incoming.

Revadike commented 3 years ago

SteamDB links shouldn't appear for any item that is not appID or subID. If you find an example, try disabling all plugins and reloading the page. If it is still there, (small) bug bounty incoming.

It's gone now, but it was definitely there.

bartervg commented 3 years ago

Steps to reproduce the bug

Trivial

Less trivial than expected. Next time screenshot it!

SteamDB links should appear for Steam apps and packages only. It's possible that Game Pass was mistakenly listed as a Steam app, but it appears to be fixed now.