search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Inconsistent game titles #252

Open Revadike opened 3 years ago

Revadike commented 3 years ago

Describe the bug

Game titles change depending on what page you view them. Items can have multiple titles, but it's not consistent at all which title is displayed, causing often mild confusion.

Example of the bug

https://barter.vg/u/48e/o/4003144/ => Shown as 'NOGIBATOR' https://barter.vg/u/48e/o/ (crafting an offer) => Shown as 'Nogibator: Way Of Legs'

Expected behavior

Both show as the same title

Screenshots

image image

bartervg commented 3 years ago

I believe this is due to the For Steam games, show preference image The offer shows the app titles regardless of preference. There's some risk in changing it to reflect each user's preference. The offer shows Game X No, look again, it is Game Y Perhaps the safer, although more cluttered option should be to show both titles (if different) on the offer page.

bartervg commented 3 years ago

Offers should

  1. display app titles (wontfix)
  2. display store page titles (even badder design)
  3. display titles based on user preferences (choice matters)
  4. display both (illusion of choice)
Revadike commented 3 years ago

I'm not sure what the problem is? The user preference is fine. It should just display it consistently everywhere.

bartervg commented 3 years ago

The problem is that the store title could be wrong and the app title could be correct. The sender could see the app title, the receiver could see the store title, and then have a fight over which game should have been sent. Unlikely, but with thousands of offers each week, even sub-1% chances will happen regularly.

Revadike commented 3 years ago

It should still link to the same store page. Even barter's item page should clear up any confusion since it displays all titles on the top. So, I really don't think this is a problem at all. That the store title or app title could be incorrect is a different issue altogether.