bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Key(s) sent on Steam button #256

Open bartervg opened 3 years ago

bartervg commented 3 years ago

What problem does this feature address?

After accepting an offer and Steam request, it can be convenient to asynchronously exchange keys. To increase the likelihood that the other side notices this, many senders respond in the offer key sent on Steam. However, for those that sent the offer, despite fulfilling the offer, and now waiting for the other side to respond, the offer remains is a need to act status for the offer sender.

Describe a solution

A button near chat Key(s) sent on Steam. Clicking this would change the side to act and thus remove the need to act on offer icon. The key sender has nothing left to do but wait for the other side to respond. image

image

There could be a preference for those that do not want keys sent until chat confirmation. This would disable such button.

image

In addition, there could be a button for Steam invite sent.

Examples of similar features

Preference on when to send Steam invite and minimum offer expiration days.

Luckz commented 3 years ago

eBay-like, an "I completed my part of the trade" (= payment sent / goods shipped)! Of course it has to be optional to use this and not look like it's part of the proper etiquette, since it's only useful for async trades.

Normally it's the accepting partner who sends a friend request the moment they accept the trade, innit? Perhaps there's cases where people are at work or in the mountains and have no access to their Steam account, then separating the invite makes sense I guess. It doesn't seem common enough to show a button about it for everyone. Not sure if a preference to add such an exotic button is worth the additional cognitive load on our code output creatures.

If a user set a preference to refuse key ambushes, the other partner should see the disabled button say as much.

I sent key(s) on Steam confirm trade in chat before sending keys!

Revadike commented 3 years ago

Yes, please make it optional. I'm lazy and don't want to change my trade bot to add this extra step during trading. Personally, I don't get it. It's pretty much the same as typing the message "I sent steam keys" but then in button form.

bartervg commented 3 years ago

Yes, please make it optional. I'm lazy and don't want to change my trade bot to add this extra step during trading.

Yes, it would be optional.

Personally, I don't get it. It's pretty much the same as typing the message "I sent steam keys" but then in button form.

The difference is that it would change the side to act. For example, if I've sent Steam invites and keys and I'm waiting for everyone to respond. I shouldn't see image. It should be the users that needs to act that see that.

Revadike commented 3 years ago

It's worth mentioning that Key(s) sent on Steam is not a very good name for this button. It's too specific and doesn't cover all cases. Something like Expected items sent to other party applies to all cases.