search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

Proposal: Count completed offers only after both sides have completed them #303

Open bartervg opened 1 year ago

bartervg commented 1 year ago

Proposal

Do not update Trades until both sides have completed the offer.

Completed offer count, displayed as Trades on profiles, count the number of offers that both sides have completed. However, when one sides completes an offer, Trades immediately increments. Even if the other side does not complete the offer, the count will remain that way for up to twelve hours. Twice a day, all offer stats are recalculated, and will no longer include partially completed offers.

Rationale

Adding but then subtracting partially-completed offers from Trades leads to confusion. The number of completed offers declines seemingly without cause. In addition, clicking to complete an offer will add not just one completed offer, but all previously partially-completed offers. For some users, this number could be substantial. If those offers remain partially completed, the count will decline when the offer statistics are recalculated. This means that Trades increments by 2 or more upon clicking complete, then decrements by 2 or more several hours later.

In addition, a malicious new user could immediately accept and complete several offers, bypassing any new user restrictions without any other users completing the offers.

On the negative side, this change could lead to the dissatisfaction and confusion of clicking complete and not seeing the Trades count increment immediately.

bartervg commented 1 year ago

/remind me in a week

reminders[bot] commented 1 year ago

@bartervg set a reminder for Dec 23rd 2022