search

bartervg / barter.vg

Track and hold discussion on Barter.vg bugs, enhancements, and other issues
https://barter.vg
MIT License
20 stars 4 forks source link

ITAD links go to wrong pages (sometimes) #66

Closed bartervg closed 4 years ago

bartervg commented 4 years ago

Describe the bug Some ITAD links lead to the wrong or blank pages

Steps to reproduce the bug

  1. Go to https://barter.vg/i/107909/
  2. Click history or IsThereAnyDeal link
  3. https://isthereanydeal.com/game/celestial/info/ is the wrong page

Expected behavior Link to the correct page, although in this case, not sure where the correct ITAD page is located.

Screenshots (if applicable) image clicking history link goes to image which is a different game image

Device (if relevant) N/A

Additional context There's an API https://api.isthereanydeal.com/v01/game/plain/id/?key=&shop=steam&ids=app%2F377160%2Capp%2F96100%2Csub%2F28187%2Csub%2F1245

bartervg commented 4 years ago

I registered on ITAD for API key since Get plain is protected. Next step will be setting up a crontab to regularly check and update ITAD plains.

bartervg commented 4 years ago

Every day, Steam appIDs that don't have ITAD plains will be checked with the ITAD API. todo:

bartervg commented 4 years ago

All appID and subIDs have been checked and will be rechecked at the rate of 700 items per day (~5 months to recheck entire database) along with new app and sub IDs. Manually editing ITAD plain will place the modified plain at the back of the recheck queue.

Adding 100k ITAD plains crashed the bundle page because the page selected the entire table (out of memory error). Previously, there were 36 rows in the table. Therefore, the bundle charts will not have the ITAD plains until this is fixed (tag this as bad design).

bartervg commented 4 years ago

Out of memory bug fixed on the bundle pages, and ITAD links use the correct plains. However, the original bug with Celestial remains. This appears to be an ITAD bug where 2 different games and appID are combined onto the same plain. https://store.steampowered.com/app/1128330/ https://store.steampowered.com/app/1194910/ image third Celestial game, a potential problem in 11 days, https://store.steampowered.com/app/1101050/

Potential improvement: use different API https://api.isthereanydeal.com/v01/game/plain/list/?key=&shops=discord to update all plains every day rather than a few hundred at a time.