search

bartholomej / ngx-scrolltop

Lightweight, Material Design inspired "go to top button". No dependencies. Pure Angular!
http://bartholomej.github.io/ngx-scrolltop/
MIT License
30 stars 3 forks source link

Angular 18 Support #100

Closed ericrovtar closed 3 months ago

ericrovtar commented 4 months ago

@bartholomej Me again. :)

I saw you updated the package version to 18, but it looks like the peer dependencies are set to be <18. Is there any chance to get these updated to include Angular 18?

Thanks!

ericrovtar commented 3 months ago

Just wanted to check in on this. I believe all that has to be updated is to include Angular 18 as the peer dependency in package.json:

"peerDependencies": { "@angular/common": ">=16 <=18", "@angular/core": ">=16 <=18" },

I tried pushing a PR with this change for you, but it won't let me.

bartholomej commented 3 months ago

Hi @ericrovtar Thx for your suggestion.

Fixed in v18.0.1

Let me know ;)

ericrovtar commented 3 months ago

@bartholomej Works like a charm! Thanks. :)