search

bartificer / programming-by-stealth

Resources for the Programming By Stealth blog/podcast series at https://bartb.ie/pbs.
MIT License
23 stars 17 forks source link

fix: PBS21 correct typo #48

Closed SteveMattan closed 7 months ago

SteveMattan commented 7 months ago

In the section "jQuery and CSS", in the 'show/hide/toggle' example the variable is declared as "aniTime" and then used as both "aniTime" and "anyTime". "ani" was changed to "any" so that it is "anyTime" throughout.

podfeet commented 7 months ago

Thanks for the correction!

bbusschots commented 7 months ago

@SteveMattan & @podfeet aniTime is a contraction of Animation Time, so it really was supposed to be aniTime, the actual typo was the two anyTime variables so I've reverted this PR and corrected the instalment the other way around on Master.

Steve — thanks as always for your help, your proof-reads as you visit older instalments is simply invaluable!

podfeet commented 7 months ago

Dang it - that was the very first time I approved a PR! I debated asking you first but took charge instead.

SteveMattan commented 7 months ago

Don’t worry, I’ve got more …

:-)

SteveM

On Apr 1, 2024, at 9:31 AM, Allison Sheridan @.***> wrote:

Dang it - that was the very first time I approved a PR! I debated asking you first but took charge instead.

— Reply to this email directly, view it on GitHub https://github.com/bartificer/programming-by-stealth/pull/48#issuecomment-2029764038, or unsubscribe https://github.com/notifications/unsubscribe-auth/AW4B2YGFULPZ7ZX5SSGT27DY3FOTXAVCNFSM6AAAAABFEDRNDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZG43DIMBTHA. You are receiving this because you were mentioned.