bartificer / programming-by-stealth

Resources for the Programming By Stealth blog/podcast series at https://bartb.ie/pbs.
MIT License
23 stars 17 forks source link

Some recent PBS HTML pages show "Join the Community" in the tab title. #56

Closed macLurker closed 5 months ago

macLurker commented 5 months ago

The following PBS module pages show "Join the Community" in the tab title: PBS161, PBS162, PBS163, PBS165, PBS166, and PBS167. I checked PBS150 to PBS167. All the others I checked correctly show "PBS x of X - " in the tab title. </p> <p>I compared the HTML source for the good files & the bad files. The ones that work have a top-level header "h1" with the module info. The ones that don't work have level 2 "h2". I'm not sure if that's related, but it's a place to start.</p> <p>I often have multiple PBS pages open at one time. Not having the module number in the tab title makes getting the page I want difficult since they all look the same. I have to click on the tab to see if it's the page I want at the moment. Very annoying. So please fix. Thanks. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/podfeet"><img src="https://avatars.githubusercontent.com/u/12651464?v=4" />podfeet</a> commented <strong> 5 months ago</strong> </div> <div class="markdown-body"> <p>If that is actually the root cause, I can easily fix it. Please identify the pages that have the problem.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/podfeet"><img src="https://avatars.githubusercontent.com/u/12651464?v=4" />podfeet</a> commented <strong> 5 months ago</strong> </div> <div class="markdown-body"> <p>Or, at least a couple of them so we can run a test</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/macLurker"><img src="https://avatars.githubusercontent.com/u/53100530?v=4" />macLurker</a> commented <strong> 5 months ago</strong> </div> <div class="markdown-body"> <p>The following PBS module pages show "Join the Community" in the tab title: PBS161, PBS162, PBS163, PBS165, PBS166, and PBS167. </p> <p>I only checked PBS150 to PBS167. But it's a recent problem. There doesn't seem to be a way to do a group search.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/podfeet"><img src="https://avatars.githubusercontent.com/u/12651464?v=4" />podfeet</a> commented <strong> 5 months ago</strong> </div> <div class="markdown-body"> <p>Confirmed that was the problem. I just changed PBS 161's first line to H1 and now the title shows in the tab bar. I'm going to leave this open until I fix all that you've noted. I'll also talk to @bartificer about fixing the the template he uses for the shownotes. </p> <p>Thanks @macLurker!</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/podfeet"><img src="https://avatars.githubusercontent.com/u/12651464?v=4" />podfeet</a> commented <strong> 5 months ago</strong> </div> <div class="markdown-body"> <p>All installments past PBS 160 now start with an H1 tag so their tabs now show the title of the episode. I clicked every installment up to and including 160 to ensure they were all presenting correctly.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>