padding and separator types get confused on second generate

[podfeet]

Steps to reproduce:

• Refresh
• Open config and Settings
• Change Padding type to specified character
  • choose ^
• Generate - should see padding of ^^ on each end
• Now without refreshing, change padding type to "Use Separator character". Leave Type of Separator at random character
• Generate again
• Should still see ^^ as padding

It gets weirder.

• Now change separator type to Specified character, like "-"
• Padding type is still set to use separator character
• Generate
• padding is still ^^ and separator character is NOT "-"

[hepabolu]

I can confirm this.

[hepabolu]

@podfeet, @pricemi115 and @macLurker Before I merge this into main, could you test this code in branch issue-55 ?

[podfeet]

not sure what happened - all I did was click on AppleID preset

[podfeet]

same thing with all of the presets I tried

[hepabolu]

Fixed

[pricemi115]

I seem to be ok, @hepabolu and I have the function mentioned in @podfeet's comment.

[podfeet]

Good thing this was such a well-documented issue 😜 - I was able to follow the tests described and confirm that the issue has been fixed.

[pricemi115]

@podfeet , is your branch history exactly what Helma has in the issue-55 branch? Did you do a merge or rebase when trying to get her code and had a merge contention go sideways?

[pricemi115]

@hepabolu - tried all of the presets and various custom settings. Seemed to work as expected

[podfeet]

@pricemi115 she fixed the problem before you saw it I think. it's all good now.

[pricemi115]

Timing, as they say, is everything!!

And DUH!!! The commit message of the most recent commit says it all

[hepabolu]

Thanks guys. I'll merge the code to main and close this issue.