search

bartificer / xkpasswd-js

The official JavaScript port of the Crypt::HSXKPasswd Perl module.
https://bartificer.github.io/xkpasswd-js/
BSD 2-Clause "Simplified" License
62 stars 11 forks source link

fix: #61 add screenreader support for password copy buttons #62

Closed pricemi115 closed 9 months ago

pricemi115 commented 9 months ago

Each password copy button with have a screen reader label of "Copy Password#n"

pricemi115 commented 9 months ago

Hi @hepabolu - this is to get the "controversial" password copy buttons to play nice with screen readers and make @podfeet happy ;)

podfeet commented 9 months ago

I added this to the copy button issue as well - there are newly introduced VoiceOver errors in this latest implementation. I made a video to show you where they are:

https://share.cleanshot.com/Smh9VHbQ

pricemi115 commented 9 months ago

🤦‍♂️maybe we should have @podfeet do the next review 😉

Very helpful video btw.

pricemi115 commented 9 months ago

Submitted #63 for the issues @podfeet identified