search

bartificer / xkpasswd-js

The official JavaScript port of the Crypt::HSXKPasswd Perl module.
https://bartificer.github.io/xkpasswd-js/
BSD 2-Clause "Simplified" License
62 stars 11 forks source link

Create URL with custom settings #94

Closed irsheep closed 5 months ago

irsheep commented 5 months ago

Generates a URL with the user custom configuration settings, the URL can be used to re-open the page with the same configuration.

The settings are converted from JSON to a CSV and encoded to a Base64 string, I took this approach as encoding the JSON object was creating a large URL. When encoding to base64 some characters are replaced so the encoded string is URL save.

Example: https://beta.xkpasswd.net/?c=ZW5nbGlzaCw0LDQsOCxDQVBJVEFMSVNFLEZJWEVELExRLElVQWtKVjRtS2kxZkt6MDZmSDRfTHk0NywyLDIsTk9ORSw4LFJBTkRPTSwsSVVBa0pWNG1LaTFmS3owNmZINF9MeTQ3LDIsMg

bbusschots commented 5 months ago

Thanks — lots of work here for a cool and useful feature.

At first glance this looks fantastic, but i'm not familiar enough with the code base to review it, so I've asked Helma to review it. Best in mind she has some stuff going on in her personal life so it might be a little longer than it normally Would be until she gets a chance to

hepabolu commented 5 months ago

Thanks for the feature

hepabolu commented 5 months ago

@irsheep This feature allows me to consolidate all loading and saving of configurations in one place. Thanks a lot! I need to rearrange and rename the code to match the other classes, but it will definitely keep its prominent functionality.

podfeet commented 2 months ago

@irsheep I know this issue is closed but I wanted to tell you that in today's episode of Programming By Stealth, @hepabolu taught @bbusschots and me about how XKPasswd-js has implemented Model View Controller, you got a huge shout out during the episode. at about 1 hour and 3 minutes, she told us about your PR and what a fantastic solution it was to give us a way to save a configuration. Then she went on to explain how because of MVC, it made it easier and cleaner to implement into the bigger project.

I wanted to thank you for your contribution and to make sure you heard the show and the nice things said about you. At the link for the show notes for Programming By Stealth 171, you can listen to the whole thing, or to jump to 1:03 to hear us talk about your work.

https://pbs.bartificer.net/pbs171