search

bartneck / swiML

A project to formalise swimming programs using XML
MIT License
2 stars 2 forks source link

continue does not respect laps #102

Open bartneck opened 2 months ago

bartneck commented 2 months ago

When laps is defined as the unit of length measure, then the repetition should report the overall length as laps. Right now it converts it to meters.

bookExamples/patterns/handshake/handshake-program.html

It should show the total number of laps in the continue element.

SCR-20240422-obxx
calloc262 commented 1 month ago

should be a fix for this in the latest version

bartneck commented 1 month ago

The fix does not seem to work. Could you please try it out with the bookExamples/patterns/handshake/handshake-program.xml program?

bartneck commented 1 month ago

This issue does relate to issue "lengthUnits can be set to lapse #104". The definition of <lengthUnit> has to be clarified. Originally, it was meant as a default for the instructions. The total length of the program would then also be shown in this unit.

But it was also used to define the poolLength. The pool length cannot be laps and hence we decided to remove this option. We also changed the the way how length is defined in the instructions. We now have explicit distance, laps and time. Hence we no longer need a "default" unit of measure. Or at least we need to define better what consequences it might have.

We might need to consider including a new element that is specifically used as the default, such as <defaultLength>. It could be used to set the unit in which the program total is set.