Flickering background video

[real-uplink]

Issue short description

I have an issue with flackering background video when navigating in the menu and having Show_VideoBackground enabled.

Setup

• RaspberryPi 4B with XBian and Kodi Matrix
• Amber Skin in the versions 3.4.11 and 3.4.32

Steps to reproduce error

• Use similar setup as described above
• Activate Show_VideoBackground in skin settings
• navigate either to home and see a flickering video playback (error exists in 3.4.11 and persists in 3.4.32)
• navigate in movies selection and see a black window/flickering video playback (error did not exist in 3.4.11)

Solution approach

• I tracked down one error cause of the flickering introduced from version 3.4.11 to version 3.4.32 by try and error, replacing different files and diffing
• I identified the commit 23fc52cb0bd6327d0be67a3aae38d4181e8b1669 and the file _1080i\IncludesBackgrounds.xml as one problem cause.
• If you do a diff on this commit you get two problems introduced:

1. flickering by lines 441..446:

   <control type="videowindow">
   <width>1280</width>
   <height>720</height>
   <right>0</right>
   <top>0</top>
   </control>

2. black overlay by line 436:

   <visible>Player.HasVideo + [Skin.HasSetting(Show_VideoBackground) | [Skin.HasSetting(AutoPlayTrailer) + !$EXP[56_NetflixTrailerWindow]]]</visible>

Full solution

• I identified this one location as error cause, but there may be more sources for the flickering in the movie selection introduced in between 3.4.11 and 3.4.32. Please track them down as well
• The flickering in the main menu/home screen was already introduced until 3.4.11 and is still persisting. I hope you can track down this error as well with my hints from above.

[real-uplink]

Closing Information

The flickering problems are gone for me with the last XBian/Kodi update. Here are the version numbers for my working setup:

• XBian: 111.0 - Bullseye 10.0 (Kernel: Linux 5.15.80+)
• Kodi: 19.5.0 GIT: 20221231
• Amber Skin: 3.4.32

I close the issue as it seems to be no problem with the new version anymore.