bartongroup / RATS

Relative Abundance of Transcripts: An R package for the detection of Differential Transcript isoform Usage.
MIT License
32 stars 1 forks source link

(dev. ver.) Why did a crash condition pass the tests? #42

Closed fruce-ki closed 6 years ago

fruce-ki commented 6 years ago

This issue applies to dev versions between 0.6.0-3 and 0.6.0-7. This bug has now been resolved, but formal testing should be put in place for such scenario.

With the introduction of scaling vectors in place of scaling factors, some code omissions caused RATs to crash. The tests failed to pick up the crash at all. Probably because the breaking code is only executed when scaling is requested, and none of the old tests have a scaling scenario.