search

bartosz-antosik / vscode-spellright

Multilingual, Offline and Lightweight Spellchecker for Visual Studio Code
Other
359 stars 36 forks source link

spellright error when line is removed #237

Open kinghat opened 5 years ago

kinghat commented 5 years ago

in a markdown file i noticed that when you have not corrected all spelling mistakes and you remove a line from the document that it still says there is a mistake but is on the original line:

here you can see it says 'im' is spelled incorrectly on line 15 at the 12th character: image

here you can see it says the same thing though lines have been removed from the document: image

not part of the issue it isn't able to correctly suggest to me what should be done with 'im'?

bartosz-antosik commented 5 years ago

Hi! Not part of the issue: Could you provide some background, e.g. what OS is this (Spell Right uses different back-ends on different platforms)?

kinghat commented 5 years ago

im on KDE neon. so ubuntu 18.04 base.

bartosz-antosik commented 5 years ago

So the answer to the part that is not part of the issue is that it depends on the dictionary! See here I am using dictionary from Ubuntu's (Kubuntu's to be precise) 18.10 /usr/share/hunspell directory (which you may symlink to the Spell Right's dictionaries folder BTW):

screenshot_20181217_224226

It is beyond the scope of my work on this extension to explain differences between dictionaries. Please see README for some notes on backends and dictionaries.

kinghat commented 5 years ago

So the answer to the part that is not part of the issue is that it depends on the dictionary! See here I am using dictionary from Ubuntu's (Kubuntu's to be precise) 18.10 /usr/share/hunspell directory (which you may symlink to the Spell Right's dictionaries folder BTW):

It is beyond the scope of my work on this extension to explain differences between dictionaries. Please see README for some notes on backends and dictionaries.

ty for your reply. i read the readme before i posted and had it symlinked already. both dictionaries have 'I'm' listed respectively. i can get the suggestion to 'I'm' if i type 'i'm' but not 'im'/'Im'. im also not showing both dictionaries to choose from in VSCode, just the ones i downloaded from the readme link as suggested. though, i dont think this really matters because like i said, 'I'm' is in both dictionaries.

image

image

its possible im still doing something wrong. im sorry.i should have made another issue with this.

as to the original, more important issue, are you able to reproduce?

bartosz-antosik commented 5 years ago

I am sorry it took this much time to return to this issue. It also seems that I cannot reproduce the issue, maybe I am doing something wrong:

markdown-deleting-line

Looks like once I delete the line the diagnostic notice relating to the line disappears.

Could you please test whether this is not an interference with another extension: Could you please disable other extensions (at least those related to Markdown, but it still may be some other extension) and check whether thie issue still happens?