bartosz-antosik / vscode-spellright

Multilingual, Offline and Lightweight Spellchecker for Visual Studio Code
Other
359 stars 37 forks source link

MacOS: No M1 lib/bin/spellchecker-darwin*arm64.node files #477

Open serge-ivamov opened 2 years ago

serge-ivamov commented 2 years ago

This plugin does not contain binary libraries for Apple Silicon if installed as "ext install ban.spellright".

$ ls lib/bin
spellchecker-darwin-12.0.4-x64.node spellchecker-rpm-12.0.4-x64.node
spellchecker-darwin-13.1.7-x64.node spellchecker-rpm-13.1.7-ia32.node
spellchecker-deb-12.0.4-ia32.node   spellchecker-rpm-13.1.7-x64.node
spellchecker-deb-12.0.4-x64.node    spellchecker-win32-12.0.4-ia32.node
spellchecker-deb-13.1.7-ia32.node   spellchecker-win32-12.0.4-x64.node
spellchecker-deb-13.1.7-x64.node    spellchecker-win32-13.1.7-ia32.node
spellchecker-rpm-12.0.4-ia32.node   spellchecker-win32-13.1.7-x64.node
timj commented 2 years ago

Thank you. That explains why spellright thinks it is enabled but is not working for me at all on my M1 laptop.

cdbattags commented 2 years ago

Any update on this?! Would love to use it on my new MacBook.

k321rf commented 2 years ago

As a quick workaround just download the arm64 binaries from https://github.com/bartosz-antosik/vscode-spellright/tree/master/lib/bin and place it into the .vscode/extensions/ban.spellright-3.0.60/lib/bin.

If MacOS blocks to open them then go to the Security & Privacy menu and grant the permissions to open it.

serge-ivamov commented 2 years ago
$ xattr -c ~/.vscode/extensions/ban.spellright-3.0.60/lib/bin/*arm64.node
MVND commented 2 years ago

As a quick workaround just download the arm64 binaries from https://github.com/bartosz-antosik/vscode-spellright/tree/master/lib/bin and place it into the .vscode/extensions/ban.spellright-3.0.60/lib/bin.

If MacOS blocks to open them then go to the Security & Privacy menu and grant the permissions to open it.

I am on an M1 Mac and have done this but the extension still isn't working. Any command I choose from the command palette results in something like Command 'SpellRight: Configuration Update' resulted in an error (command 'spellright.configurationUpdate' not found), which was the issue I was getting before trying this workaround

cysouw commented 2 years ago

The binary spellchecker-darwin-17.2.0-arm64.node seems to be missing

borekb commented 2 years ago

One annoying thing is that each update breaks this – I had everything working for v3.0.60 and now have to re-do it for v3.0.62 (initially, I didn't even notice that spell checking stopped working). Hopefully this will be added to the extension itself one day 😊.

UPDATE: no, sorry, I already had all the *-arm64.node files in my ~/.vscode/extensions/ban.spellright-3.0.62/lib/bin. It must be another reason why spell checking isn't working.

UPDATE 2: I'm hitting this: https://github.com/bartosz-antosik/vscode-spellright/issues/502.