search

bartosz-antosik / vscode-spellright

Multilingual, Offline and Lightweight Spellchecker for Visual Studio Code
Other
359 stars 36 forks source link

Extension not working properly on VSCode 1.74.0 #536

Closed rotemdan closed 1 year ago

rotemdan commented 1 year ago

Suggestions either don't appear, don't disappear or don't update correctly after one error is found, even after the error is fixed.

I'm not sure if this is a VSCode issue only, since it worked properly on previous versions, but I've also reproduced the issue on latest Insider build (1.75.0-insider) with only the Spell Right extension installed:

spellright1

The video was captured on:

Version: 1.75.0-insider (user setup)
Commit: b92894493e6f971a3c71912d823e699d3a05d643
Date: 2022-12-08T05:20:51.149Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: Yes

Edit: The extension page logs many uncaught errors: Screenshot_9

Maybe this is this related to some breaking API change that was introduced in 1.74.0?

bartosz-antosik commented 1 year ago

I will have a look at this. Looks strange, indeed.

kakoeimon commented 1 year ago

I have the same issue, but it looks like it is a VSCode regression. I had 1.7.4 (no iinsider) I installed 1.7.2 and everything works as expected.

SR-- commented 1 year ago

Same here, not working on 1.7.4

hjhilden commented 1 year ago

Same, stopped working with version: 1.74.0. Also getting the Cannot read properties of undefined (reading '_line')

gdavisSMAX commented 1 year ago

I am getting the same behavior. Running VSC 1.74.0 / Spell Right 3.0.90 on a Windows 11 laptop.

j-lakeman commented 1 year ago

Confirmed with Version: 1.74.0 running on Ubuntu 22.10 as well as macOS Big Sur, so this indeed seems to be a VS Code issue.

bartosz-antosik commented 1 year ago

Hi! I hope recent changes have fixed the above. It may have been My fault by sticking to old properties names.

SR-- commented 1 year ago

Hi! I hope recent changes have fixed the above. It may have been My fault by sticking to old properties names.

Seems fixed. Many thanks for this and generally for this super-useful extension!

rotemdan commented 1 year ago

I've updated to the new version and the issue seems to be fixed. Thanks! You can close the issue if you wish.

bartosz-antosik commented 1 year ago

@SR-- Thanks. I wish I could polish it here and there but hasn't got enough time recently.

SR-- commented 1 year ago

This one has 339k installs. You are truly lucky if you have another project that is more important than keeping 339k humans happy. ;)

bartosz-antosik commented 1 year ago

@SR-- Thank you! I will put your message in frame and hang s/where around to look at in the moments of doubt!