bartosz-antosik / vscode-spellright

Multilingual, Offline and Lightweight Spellchecker for Visual Studio Code
Other
360 stars 37 forks source link

only download specific file for OS #553

Open j-lakeman opened 1 year ago

j-lakeman commented 1 year ago

Below ncdu output of the spell right extension folder. Wouldn't it be better to only download the one system-specific file? For one person it's not a lot of data, but recurring with every update for thousands of people it is just unnecessary imho. Other than that, great extension!

ncdu 1.18 ~ Use the arrow keys to navigate, press ? for help
--- /home/xxx/.vscode-oss/extensions/ban.spellright-3.0.116-universal/lib/bin --------------------------
                                            /..
    1,1 MiB [#############################]  spellchecker-win32-19.0.11-x64.node
  876,0 KiB [#######################      ]  spellchecker-win32-19.0.11-ia32.node
  560,0 KiB [##############               ]  spellchecker-win32-22.3.8-x64.node
  468,0 KiB [############                 ]  spellchecker-win32-22.3.8-ia32.node
  440,0 KiB [###########                  ]  spellchecker-macos-22.3.8-x64.node
  440,0 KiB [###########                  ]  spellchecker-macos-19.0.11-x64.node
  428,0 KiB [###########                  ]  spellchecker-macos-19.0.11-arm64.node
  428,0 KiB [###########                  ]  spellchecker-macos-22.3.8-arm64.node
  428,0 KiB [###########                  ]  spellchecker-linux-19.0.11-ia32.node
  424,0 KiB [###########                  ]  spellchecker-linux-22.3.8-ia32.node
  420,0 KiB [###########                  ]  spellchecker-linux-19.0.11-x64.node
  420,0 KiB [###########                  ]  spellchecker-linux-22.3.8-x64.node
bartosz-antosik commented 1 year ago

I would love that. Just do not have any idea how to do this, because the binaries are matched by the electron and the rules on how it is done are not clear to me.

j-lakeman commented 1 year ago

Cheers! Maybe that https://github.com/vscode-shellcheck/vscode-shellcheck/pull/805 helps.