search

bartosz-antosik / vscode-spellright

Multilingual, Offline and Lightweight Spellchecker for Visual Studio Code
Other
358 stars 36 forks source link

Extension fails to load in VS Code 1.90.0 #578

Open reduckted opened 1 month ago

reduckted commented 1 month ago

VS Code updated to a new Electron version. https://code.visualstudio.com/updates/v1_90#_electron-29-update

Same problem as these issues:

https://github.com/bartosz-antosik/vscode-spellright/issues/513 https://github.com/bartosz-antosik/vscode-spellright/issues/536 https://github.com/bartosz-antosik/vscode-spellright/issues/561

rotemdan commented 1 month ago

The extension host error log shows:

2024-06-06 09:56:29.973 [error] Activating extension ban.spellright failed due to an error:
2024-06-06 09:56:29.973 [error] TypeError: Cannot read properties of null (reading 'Spellchecker')
    at Object.<anonymous> (c:\Users\X\.vscode\extensions\ban.spellright-3.0.124\lib\bindings.js:46:25)
    at o._compile (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:1271)
    at Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
    at Module.load (node:internal/modules/cjs/loader:1098:32)
    at Module._load (node:internal/modules/cjs/loader:945:12)
    at c._load (node:electron/js2c/node_init:2:13672)
    at E._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:176:5901)
    at n._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:30787)
    at t._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:138:33074)
    at Module.require (node:internal/modules/cjs/loader:1122:19)
    at h (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)
    at Object.<anonymous> (c:\Users\X\.vscode\extensions\ban.spellright-3.0.124\src\spellright.js:18:18)
    at o._compile (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:1271)
    at Module._extensions..js (node:internal/modules/cjs/loader:1311:10)
    at Module.load (node:internal/modules/cjs/loader:1098:32)
    at Module._load (node:internal/modules/cjs/loader:945:12)
    at c._load (node:electron/js2c/node_init:2:13672)
    at E._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:176:5901)
    at n._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:173:30787)
    at t._load (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:138:33074)
    at Module.require (node:internal/modules/cjs/loader:1122:19)
    at h (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\loader.js:4:647)
    at activate (c:\Users\X\.vscode\extensions\ban.spellright-3.0.124\src\extension.js:19:24)
    at J.kb (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:159:13460)
    at J.jb (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:159:13173)
    at c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:159:11198
    at async a.n (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:143:6361)
    at async a.m (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:143:6324)
    at async a.l (c:\Users\X\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:143:5781)
bartosz-antosik commented 1 month ago

HI! Thanks @reduckted for pointing out that this is a recurring problem once Electron version gets bumped. I am working on update just there are some unexpected problems from the side of Github Actions runners. Will complete it as soon as possible.

nonoash commented 1 week ago

Has it been fixed and broke again in the meantime? I see that last release is after the creation of this issue and last update is today. I just installed the plugin, it's not working and get the same log as @rotemdan, just want to make sure it's not on my end

rotemdan commented 1 week ago

I've updated to the new versions (3.0.126, 3.0.128 and 3.0.132) as soon as they were released, and was still getting the same error. I assumed the issue wasn't fixed since it is still open.

Now that I look at the release note for 3.0.126 (6 June) it shows:

Binaries updated for Electron 29.x.

So I'm not sure why it isn't working. My current installed version is showing v3.0.132.