search

bartoszbielawski / LEDMatrixDriver

A replacement for Arduino's LedControl library
MIT License
74 stars 25 forks source link

Documentation updates #18

Closed scottchiefbaker closed 5 years ago

scottchiefbaker commented 5 years ago

Update the README and MarqueeText example so they're more friendly for amateurs (like me)

bartoszbielawski commented 5 years ago

Thanks :)

scottchiefbaker commented 5 years ago

Would you be interested in me updating the other examples so they're all consistent? I can whip up another PR if it's something you think would be helpful.

bartoszbielawski commented 5 years ago

Sure, why not. I'd prefer to define the size in terms of segments as this is the parameter passed to the constructor. Maybe I could add getColumn() to the interface to make it clear how many columns are available...?

scottchiefbaker commented 5 years ago

Are there any cases where this library would be used that are NOT 8x8 segments? If so it probably would just be easier to define a number of segments.

Also in the old code it talks about 32x8 = 31x7? I tried the example with both and they seemed to work fine? For sanity I think we should standardize on 32x8 (and if need be change it in the library itself).

bartoszbielawski commented 5 years ago

Are there any cases where this library would be used that are NOT 8x8 segments? If so it probably would just be easier to define a number of segments.

No that I know of. You could use it in 7seg mode but then it uses a different API.

Also in the old code it talks about 32x8 = 31x7? I tried the example with both and they seemed to work fine? For sanity I think we should standardize on 32x8 (and if need be change it in the library itself).

I'm pretty sure this constant wasn't even used. drawSprite() calls have the height hard coded as 8.