search

bartoszbielawski / LEDMatrixDriver

A replacement for Arduino's LedControl library
MIT License
75 stars 25 forks source link

Make setColumn() a lot simpler and actually work. #28

Closed scottchiefbaker closed 5 years ago

scottchiefbaker commented 5 years ago

I'm not sure what the bitshift was trying to do, but it does not work. This drastically simplifies this call and also makes it possible to draw a straight column (it was completely bjorked before).

scottchiefbaker commented 5 years ago

Looking at this deeper... perhaps I misunderstand what it's used for. There are no references to this function in the library itself, or any of the examples. I assumed it was to draw a solid vertical line on the matrix, but that may be incorrect?

scottchiefbaker commented 5 years ago

Aha... that makes more sense. Without anything to call it, I wasn't sure what the intention was. Clearly I misunderstood. Please ignore this.

bartoszbielawski commented 5 years ago

My marquee code uses it to put characters on the display. I have them organized in columns and the width of chars is variable. This was I just loop over columns of a char. Feel free to write an example, but please wait for the other merges first. The API for reversing displays is going to change very soon!