bartoszbielawski / LEDMatrixDriver

A replacement for Arduino's LedControl library
MIT License
74 stars 25 forks source link

Support for 7-segment displays. #9

Closed Sthing closed 6 years ago

Sthing commented 6 years ago

Hi Bartosz,

Thank you for the library.

I am using it to control 7-segment displays like these:

This pull request adds three new functions (and an example):

I hope you find it useful.

Best regards, Søren.

bartoszbielawski commented 6 years ago

Hi Søren,

I have checked your code and it looks fine. Before I merge it I have one question to ask.

Could you tell me why did you device to use my library in place of the standard one? I've optimized mine to be able to run multiple modules as a single display. I never had problems with refresh rate when using single displays (such as this 8x7seg or the clock display). My biggest setup is 8x(8x8) with 50 ms refresh rate and on that one I could see the lag.

Regards, Bartosz

Sthing commented 6 years ago

Hi Bartosz,

Thank you for replying.

I am not sure which library you refer to as "the standard one". I have used https://github.com/wayoda/LedControl before, but it does not compile for the ESP8266 without a patch.

I also liked that your library used hardware SPI and the MIT License.

/Thing

bartoszbielawski commented 6 years ago

Yes, I consider LedMatrix to be the default one. I have used it before I got tired of the slowness. Must have patched it myself or they broke it after I have stopped using it.

Well, okay. I'm wasn't preparing a release so while I will merge this the version may stay the same for some time.

Cheers, Bartosz

Sthing commented 6 years ago

Thanks!