search

bartoszek / AUR-cloudcompare

0 stars 5 forks source link

patched tbb #13

Closed muellerbernd closed 2 years ago

muellerbernd commented 2 years ago

Hey. I had some trouble with tbb after the last updates, so I created a patch for this package. While compiling there can be some issues with tbb in the file /usr/include/oneapi/tbb/profiling.h .Dirty fix: Follow the compiler and comment the lines out, which cause the problems.

bartoszek commented 2 years ago

Sorry, but it wont fly. Only genuine patch for tbb no wonkery 😏

bartoszek commented 2 years ago

@muellerbernd I thought about pushing prev version on tbb to AUR in order for the cloudcompare build to be tbb enabled 🤔

bartoszek commented 2 years ago

Ok, finally got my shit together and bodge a honest patch for tbb:2021 d36dfa8476a5c50bdf4035b2bf2d5d044ceafc26 :feelsgood: @muellerbernd You ware close lad, instead of removing colliding shit form tbb/profile one had to disable QT keywords:emit,signals,slots,foreach with QT_NO_KEYWORDS to prevent conflicts with tbb and patch all they subsequent occurrences in cloudcompare source. https://github.com/CloudCompare/CloudCompare/issues/1385

muellerbernd commented 2 years ago

@bartoszek it was my first pull request. I needed to use cloudcompare for a project and therefore I used the simple way and removed the colliding stuff from tbb/profile. nice that you were able to patch this :thumbsup: