search

bartoszlenar / Validot

Validot is a performance-first, compact library for advanced model validation. Using a simple declarative fluent interface, it efficiently handles classes, structs, nested members, collections, nullables, plus any relation or combination of them. It also supports translations, custom logic extensions with tests, and DI containers.
MIT License
310 stars 19 forks source link

Added the German translation #23

Closed TwentyFourMinutes closed 3 years ago

TwentyFourMinutes commented 3 years ago

Issue

12

Note

I decided against using the more common form for the wording, as this is more in line with the internal .NET exceptions.

bartoszlenar commented 3 years ago

Thank you so much for your contribution! I will include this translation in the upcoming release (most probably coming 1st of November), but there is one thing with the args placeholders (they shouldn't be translated). Please see the comment I added to the code.

bartoszlenar commented 3 years ago

I see that your PR fails some CI checks, but the errors are related to styling, nothing more.

If the IDE doesn't show you these, you can run the build script to get the full report in the console:

sh build.sh --target Compile

on windows there is also a powershell version

pwsh build.ps1 --target Compile

If you don't have time to play with this anymore (something I understand completely...), I'll take your commits on a site branch, add a commit with style fixes and push on main. Your commits will be officially part of the project, but this PR will be closed.

Or I can leave the fixes to you (just include another commit to this PR or amend the changes) and not mess up with your PR github stats :).

Up to you.

TwentyFourMinutes commented 3 years ago

Hehe, I'll surly grab those stats 😉. Will probably fix it either this evening or sometime tomorrow, if that works for you.

bartoszlenar commented 3 years ago

There is no rush, mate. I'm truly thankful for your time you're spending on this. I'm not going to release next version in October anyway (targeting first week of Nov, probably 1st of Nov), so no worries, take your time.

TwentyFourMinutes commented 3 years ago

I am truly thankful having repositories such as Validot which actually point out that having great performance doesn't necessarily mean you have to compromise on usability, which I can validate based on my personal experience. So therefore I am more than happy that I can help out in all possible ways!

TwentyFourMinutes commented 3 years ago

I am sorry that I took me so long, however the indentation should be fixed. The Unit Tests on my local machine ran without any issues. I should stop editing files with notepad++ 😄

bartoszlenar commented 3 years ago

all good, mate :). 👍

i'll publish the next version within a week or so.