search

bartsqueezy / ember-handlebars-brunch

This Brunch plugin adds support for pre-compiling Ember Handlebars templates prior to runtime
MIT License
9 stars 32 forks source link

Integration with toranb/ember-template-compiler #15

Closed gcollazo closed 10 years ago

gcollazo commented 10 years ago

I simplified the plugin's code without losing any functionality.

One advantage of this change is that toranb/ember-template-compiler is referencing handlebars npm package, so it should be much easier to keep things up to date. Also this repo is using the ember-template-compiler.js which is also used by ember-app-kit a somewhat official thing.

Also:

Is this cool?

mutewinter commented 10 years ago

:+1: love this. Awesome job @gcollazo

mutewinter commented 10 years ago

Just tried this out in my own Ember app and it compiled templates flawlessly.

zxaos commented 10 years ago

This is working for me too. It seems to bypass the #12 (and by extension #13 ) issues as well.

gcollazo commented 10 years ago

@bartsqueezy got any feedback on this?

bartsqueezy commented 10 years ago

Sorry for the delayed response everyone and for any inconveniences it has caused!

@gcollazo, this is exactly the direction I've been wanting to go with this plugin. Thanks for putting in the time to work on this. Before I merge, I first need to merge in other ember.js updates and tag this project accordingly so we can continue to provide a working environment based on the version of ember.js you're using within your brunch application. I'll make time to do this over the next few nights. Look forward to having this by end of this week!

egaba commented 10 years ago

:+1: this is awesome

jas commented 10 years ago

+1. Would prefer this over #13 and #16.

john-kurkowski commented 10 years ago

+1

gcollazo commented 10 years ago

Just updated the ember-template-compiler dependency from "~1.2" to "~1.3"

bartsqueezy commented 10 years ago

@gcollazo, I've cherry picked the commits I felt were acceptable to merge. As far as converting to use ember-template-compiler as a means of keeping the compiler file up-to-date, I decided to not include that change into this project. I've added support to have npm control versioning of Handlebars.js, instead of relying on yet one more person to stay on top of upgrading. Eventually, npm will control the versioning of the ember-template-compiler.js file as well by utilizing components-ember. However, I had problems trying to reference the 1.2.0 tag while pulling in their project via npm. Once another official ember release is processed, I'll start using them as a dependency.

Until then, this plugin has been upgraded to ember 1.2.0 and handlebars 1.1.2. Thanks everyone for your feedback and contributions!