search

bartsqueezy / ember-handlebars-brunch

This Brunch plugin adds support for pre-compiling Ember Handlebars templates prior to runtime
MIT License
9 stars 32 forks source link

ember-template-compiler version upgrade breaks ember-handlebars-brunch #24

Open blimmer opened 9 years ago

blimmer commented 9 years ago

The release of ember-template-compiler 1.9.0-alpha has broken this package. There's already a conversation about this, and it seems that there's a larger conversation on if Ember is at fault for this break or not.

Either way, the package.json of this project should be updated to prevent this issue.

blimmer commented 9 years ago

If anyone else is experiencing this problem, you can add the following to your package.json 

"ember-template-compiler": "1.7.0"
abobwhite commented 9 years ago

@blimmer I am trying to upgrade my app from Ember 1.5 to 1.9.1 and have been having problems. My brunch builds but it's not compiling templates.

I have these listed in my package.json - any thoughts?

"dependencies": {
    "javascript-brunch": ">= 1.0 < 1.8",
    "coffee-script-brunch": ">= 1.0 < 1.8",
    "css-brunch": ">= 1.0 < 1.8",
    "uglify-js-brunch": ">= 1.0 < 1.8",
    "clean-css-brunch": ">= 1.0 < 1.8",
    "jshint-brunch": ">= 1.6 < 1.8",
    "handlebars": "~2",
    "ember-template-compiler": "git://github.com/toranb/ember-template-compiler.git",
    "sass-brunch": "~1.8.8"
  }